[MacPorts] #25844: p5-perlmagick: use ImageMagick sources

MacPorts noreply at macports.org
Wed Jul 28 09:06:40 PDT 2010


#25844: p5-perlmagick: use ImageMagick sources
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  astricker@…           
     Type:  defect                   |      Status:  new                   
 Priority:  Normal                   |   Milestone:                        
Component:  ports                    |     Version:  1.9.1                 
 Keywords:                           |        Port:  p5-perlmagick         
-------------------------------------+--------------------------------------

Comment(by ryandesign@…):

 Replying to [comment:3 astricker@…]:
 > Good catch! I didn't see the {{{+perl}}} variant of ImageMagick, but
 this seems to be the best solution. IMO there is no need to use the CPAN
 module at all. The drawback is that it's not really obvious that
 PerlMagick is available through this variant (compared with the stand-
 alone package {{{p5-perlmagick}}}) and I don't know if it's possible to
 define a dependency to a variant (e.g. something like
 {{{port:imagemagick+perl}}}).[[br]]
 > [[br]]
 > For backwards compatibility I'll like to see a p5-perlmagick that is
 some kind of ''meta package'' containing no source but a dependency to the
 {{{+perl}}} variant of ImageMagick. Although I don't know if this is
 possible.

 No, it's not possible to declare a dependency on a variant; see #126. And
 I don't want to deprecate the p5-perlmagick portfile in favor of
 ImageMagick's +perl variant. I want the opposite: to deprecate
 ImageMagick's +perl variant in favor of the p5-perlmagick port. Separate
 ports are better than variants, both because of #126 and for other
 reasons. See [http://lists.macosforge.org/pipermail/macports-
 dev/2010-July/012453.html my answer to Eric's mailing list post].

 > I tried to change the {{{p5-perlmagick}}} to use the ImageMagick source.
 Haven't had success so far and the Portfile is getting messy, as several
 build steps needs massaging.

 That's what I found too.

 > My current approach is[[br]]
 > [[br]]
 >  1. Fetch the same ImageMagick archive like the {{{imagemagick}}}
 port[[br]]
 >  2. Only extract the {{{PerlMagick}}} directory[[br]]
 >  3. go ahead as before with the {{{PerlMagick}}} directory content
 (reinplace INC libs, build and install)

 I think that was my initial approach as well. But then I thought the
 included Makefile.PL should be deleted and regenerated from Makefile.PL.in
 using values relating to the currently-installed ImageMagick, but due to
 the number of things that would need to be replaced in Makefile.PL.in to
 make the new Makefile.PL, I thought about running ImageMagick's regular
 configure script to hopefully fill those values in. But then it became a
 problem of knowing which ImageMagick features to enable in this configure
 run; no matter what I selected it wouldn't match the user's ImageMagick
 port, given all the possible variants that could be selected there. Then I
 thought maybe I would have to reinplace output from MagickConfig into
 Makefile.PL to get the current values. Then I got discouraged and stopped
 working on it. Attached is the patch I had put together so far, which of
 course is now out of date w.r.t. what's in the p5-perlmagick port. It
 builds, but I'm not sure if what it builds is correct. Certainly it does
 not include improvements already in p5-perlmagick, such as for non-
 default-build_arch and universal builds.

-- 
Ticket URL: <http://trac.macports.org/ticket/25844#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list