[MacPorts] #25213: ledger-devel Portfile

[MacPorts]

#25213: ledger-devel Portfile
--------------------------------+-------------------------------------------
 Reporter:  jwiegley@…          |       Owner:  macports-tickets@…                   
     Type:  submission          |      Status:  new                                  
 Priority:  Normal              |   Milestone:                                       
Component:  ports               |     Version:  1.9.0                                
 Keywords:                      |        Port:  ledger-devel                         
--------------------------------+-------------------------------------------
Changes (by ryandesign@…):

 * cc: ryandesign@… (added)
  * port:  => ledger-devel


Comment:

 Comments:
 -----
 {{{
 maintainers         johnw at newartisans.com
 }}}
 You should obfuscate your email address:
 {{{
 maintainers         newartisans.com:johnw
 }}}
 -----
 {{{
 master_sites        http://ftp.newartisans.com/pub/ledger/:source
 }}}
 Since there is only one distfile you don't need tags:
 {{{
 master_sites        http://ftp.newartisans.com/pub/ledger/
 }}}
 -----
 {{{
 distname            ${name}-${version}
 distfiles           ${distname}${extract.suffix}:source
 }}}
 These are the default so these lines can be deleted.
 -----
 {{{
 checksums           ${distname}${extract.suffix} \
                         md5     0ab9a855719df536a85f7ea5238b8a6e \
                         sha1    e2ee9e2951fd37bac50c91046f097c11294a6e8e \
                         rmd160  72cdfe76add63425b1ade1d03479e837e9f2dafe
 }}}
 Since there is only one distfile you don't need to cite it; just list the
 checksums:
 {{{
 checksums           md5     0ab9a855719df536a85f7ea5238b8a6e \
                     sha1    e2ee9e2951fd37bac50c91046f097c11294a6e8e \
                     rmd160  72cdfe76add63425b1ade1d03479e837e9f2dafe
 }}}
 -----
 {{{
 platform darwin 9 {}
 platform darwin 10 {}
 }}}
 These platform directives are no-ops so these lines should be removed.
 -----
 {{{
 variant icu description {Enable full Unicode support} {
     if {[variant_isset python25]} {
         depends_lib-delete      port:boost+python25
         depends_lib-append      port:boost+icu+python25
     }
     else if {[variant_isset python26]} {
         depends_lib-delete      port:boost+python26
         depends_lib-append      port:boost+icu+python26
     }
     else {
         depends_lib-delete      port:boost
         depends_lib-append      port:boost+icu
     }
 }
 }}}
 None of the variants work. You appear not to have tested them. There are
 syntax errors ranging from "invalid command name "else"" ("else" needs to
 go on the same line as the closing bracket of the "if" to which it
 belongs) to "wrong # args: extra words after "else" clause in "if"
 command" ("else if" needs to be written "elseif") to "can't set
 "depends_lib": invalid depspec: port:boost+icu" (it is not possible to
 declare dependencies on variants of ports; see #126).
 -----
 {{{
 #livecheck.check     regex
 #livecheck.url       ${homepage}
 #livecheck.regex     "Latest Stable Ledger \\(Version (\\d+.\\d+.\\d+)\\)"
 }}}
 Here's a livecheck that works:
 {{{
 livecheck.check     regex
 livecheck.url       [lindex ${master_sites} 0]
 livecheck.regex     ${name}-(\[0-9.-\]+)\\.tar
 }}}

-- 
Ticket URL: <http://trac.macports.org/ticket/25213#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS