[MacPorts] #25262: openload: patch to fix compile issue in snow leopard

MacPorts noreply at macports.org
Tue Jun 15 01:16:13 PDT 2010


#25262: openload: patch to fix compile issue in snow leopard
----------------------------------+-----------------------------------------
  Reporter:  smibrahim@…          |       Owner:  ryandesign@…           
      Type:  defect               |      Status:  closed                 
  Priority:  Normal               |   Milestone:                         
 Component:  ports                |     Version:  1.9.0                  
Resolution:  fixed                |    Keywords:  maintainer haspatch    
      Port:  openload             |  
----------------------------------+-----------------------------------------
Changes (by ryandesign@…):

  * keywords:  => maintainer haspatch
  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Committed in r68834. In the future please submit unified diffs, not
 complete portfiles, so we can better evaluate your proposed changes.

 Your new portfile appears to be based on the version you originally
 submitted in #19363 and not the version that got committed to the
 repository. Your new portfile did not include the post-destroot section
 currently in the port that installs the documentation files, and it did
 include --bindir and --mandir configure args that are not necessary and
 never got committed before. Bryan explained in #19363 why these changes
 were made and you agreed to them. You should always base your diffs on the
 version currently in the repository.

 I was unable to locate any distfile for an openload 0.1.2.1. Since you did
 not change the checksums, I assumed you meant to keep the version at 0.1.2
 but increase the revision to 1. This also suggests to me you did not test
 this modification before submitting it here. Please test your
 modifications in the future before submitting.

-- 
Ticket URL: <http://trac.macports.org/ticket/25262#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list