[MacPorts] #24904: ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify

MacPorts noreply at macports.org
Wed May 19 22:42:47 PDT 2010


#24904: ice-cpp, ice-java, ice-python, ice-python25, ice-python26: simplify
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  blair@…                                                  
     Type:  enhancement              |      Status:  assigned                                                 
 Priority:  Normal                   |   Milestone:                                                           
Component:  ports                    |     Version:  1.8.2                                                    
 Keywords:                           |        Port:  ice-cpp, ice-java, ice-python, ice-python25, ice-python26
-------------------------------------+--------------------------------------

Comment(by ryandesign@…):

 ----

 Ok, here's a bigger one to [attachment:worksrcpath.diff make more use of
 worksrcpath and build.dir]. I see a lot of "${workpath}/Ice-${version}" in
 these portfiles, and this could be simplified to "${worksrcpath}". And
 there's several places where you're dealing with a specific subdirectory
 of ${worksrcpath} -- "cpp" in the ice-cpp port, "java" in the java port,
 "py" in the python ports -- and this could be further abstracted out into
 the build.dir variable. This will additionally save you from needing to
 set test.dir or destroot.dir, since both of those variables' default
 values is ${build.dir}. And this lets you eliminate some other variables
 (ice-java and cppdir) which end up being the same as ${build.dir}.

-- 
Ticket URL: <http://trac.macports.org/ticket/24904#comment:6>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list