[MacPorts] #24767: New port: thrift

[MacPorts]

#24767: New port: thrift
-------------------------------+--------------------------------------------
 Reporter:  naoya.n@…          |       Owner:  macports-tickets@…                   
     Type:  submission         |      Status:  new                                  
 Priority:  Normal             |   Milestone:                                       
Component:  ports              |     Version:                                       
 Keywords:                     |        Port:  thrift                               
-------------------------------+--------------------------------------------

Comment(by ryandesign@…):

 I mean the variants cocoa, html, hs, ocaml, st and xsd. They don't list
 any dependencies. I compiled the port once without those variants and once
 with, keeping track of how long it took (using `time`) and how much disk
 space the installed files occupy (using `du`). With your default variants,
 it took 3 minutes 40 seconds and 5.2MB of disk; adding in these additional
 variants, it took 4 minutes 12 seconds and 5.7MB of disk. So it doesn't
 take much more time or disk space to just remove these variants and build
 their functionality straight into the port, so I would recommend that
 since it would simplify the port and remove the need for some user
 choices.

 Unless these variants should actually have dependencies and you just
 haven't listed them. For example, does the ocaml variant require a
 dependency on the ocaml port? It seems to build without ocaml installed,
 so maybe not.

 Some more notes:

 The port installed /usr/local/lib/libthrift.jar, which violates the mtree.
 (Everything should be installed somewhere within ${prefix}.)

 The configure script says "configure: WARNING: unrecognized options:
 --with-python"

 You don't need to say "use_bzip2 no"; that's the default.

 You're missing the long_description keyword (see "port lint"), and your
 description is rather long. So probably the description you have now
 should become the long_description and you should write a new shorter
 string for the description.

 The perl dependency in the perl variant should be written
 "path:bin/perl:perl5" as it is in other ports (not "port:perl5").

 The php dependency in the php variant should be written
 "path:bin/php:php5" as it is in other ports (not "port:php5").

 I'm confused by the java variant. It adds the configure arg "--enable-gen-
 java=yes" but "--enable-gen-java" is already in the port's global
 configure args which is the same thing, isn't it? Should the port's global
 configure args use "--enable-gen-java=no" instead?

-- 
Ticket URL: <http://trac.macports.org/ticket/24767#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS