[MacPorts] #26554: vtk5: add cmake, tcl and tk dependencies

[MacPorts]

#26554: vtk5: add cmake, tcl and tk dependencies
-------------------------------+--------------------------------------------
 Reporter:  tonchev1@…         |       Owner:  macports-tickets@…                   
     Type:  defect             |      Status:  new                                  
 Priority:  Normal             |   Milestone:                                       
Component:  ports              |     Version:  1.9.1                                
 Keywords:                     |        Port:  vtk5                                 
-------------------------------+--------------------------------------------
Changes (by ryandesign@…):

  * keywords:  vtk, vtk5, cmake, tcl, tk =>
 * cc: css@…, dweber@… (added)
  * port:  => vtk5


Old description:

> vtk5 recipe doesn't build if cmake is not installed.
> Further, when building the default variant (which has +tcltk), build
> fails if tcl and tk are not installed.
>
> I guess they should be added to the Portfile depends_build or
> depends_lib. The following patch fixed the build for me (I'm a MacPorts
> newbie and I'm not sure it's 100% correct though).
>
> Index: graphics/vtk5/Portfile
> ===================================================================
> --- graphics/vtk5/Portfile
> +++ graphics/vtk5/Portfile
> @@ -26,7 +26,7 @@
>                      sha1    355209c485304f1b0feefcda3585d45217ffd230 \
>                      rmd160  b7abf3b9bb14a3db81608c7aa2721935ae653295
>
> -depends_build   port:readline
> +depends_build   port:readline bin:cmake:cmake
>  distname    VTK
>
>  use_parallel_build yes
> @@ -91,6 +91,7 @@
>  }
>
>  variant tcltk conflicts carbon description {Build with Tcl wrappers and
> Tk support} {
> +    depends_lib-append port:tcl port:tk
>      configure.args-delete \
>          -DVTK_USE_TK:BOOL=OFF \
>          -DVTK_WRAP_TCL:BOOL=OFF

New description:

 vtk5 recipe doesn't build if cmake is not installed.
 Further, when building the default variant (which has +tcltk), build fails
 if tcl and tk are not installed.

 I guess they should be added to the Portfile depends_build or depends_lib.
 The following patch fixed the build for me (I'm a MacPorts newbie and I'm
 not sure it's 100% correct though).

--

Comment:

 "port:cmake" would be more appropriate than "bin:cmake:cmake".

 Is only vtk5 affected, or are VTK, vtk-devel and vtk44 also affected?

-- 
Ticket URL: <https://trac.macports.org/ticket/26554#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS