[MacPorts] #26664: epubcheck @1.0.5_0 problems with shell wrapper

MacPorts noreply at macports.org
Tue Sep 28 12:46:28 PDT 2010


#26664: epubcheck @1.0.5_0 problems with shell wrapper
-----------------------------------+----------------------------------------
 Reporter:  jpenney@…              |       Owner:  macports-tickets@…                   
     Type:  defect                 |      Status:  new                                  
 Priority:  Normal                 |   Milestone:                                       
Component:  ports                  |     Version:  1.9.1                                
 Keywords:  haspatch               |        Port:  epubcheck                            
-----------------------------------+----------------------------------------

Comment(by oksmith@…):

 Well I guess anybody who uses epubcheck in batch process such as a
 Makefile will have to do everything I tried to provide in the wrapper.

 Is there any way to make better what there was instead of clobbering it?
 I am happy to try to fix it.  Please advise.

 You may want to review the script associated with the port relames.  It
 doesn't use exec or have double quotes around the $@ and is what I used as
 the starting point for this script.

 Thanks.

 Replying to [ticket:26664 jpenney@…]:
 > There are number of problems with the epubcheck wrapper script provided
 with this port:
 >
 >  * creates temporary files without using/checking TMPDIR or TEMP
 >  * merges output of STDOUT and STDERR (2>&1)
 >  * looses the exit code returned by the epubcheck application itself,
 and instead parses the combined output
 >  * looses the ability to pass files with spaces in the name (uses $@
 instead of "$@")
 >
 > I'm attaching a patch containing a simplified script that corrects these
 issues.

-- 
Ticket URL: <https://trac.macports.org/ticket/26664#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list