[MacPorts] #28956: TortoiseHg Port Submission
MacPorts
noreply at macports.org
Sun Apr 10 10:49:24 PDT 2011
#28956: TortoiseHg Port Submission
----------------------------------------+-----------------------------------
Reporter: guidolorenz@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: mercurial | Port:
----------------------------------------+-----------------------------------
Comment(by shiena.jp@…):
Hi Guido
Thank you for seeing my file.
> 1. Copying the license file and building the english documentation is a
good idea.
Thank you.
> 2. Also building czech and japanese documentation seems a bit too much
to me. I'm not sure, though -- is there a MacPorts best practice for
dealing with localized documentation?
There is especially no intention though I did all documents in the build.
> 3. Why do you manually create a symlink for thg in ${prefix}/bin? For
me, the python26 port group already created this symlink automatically.
It is my mistake. I misunderstood it while a variety of trying. A symlink
need not be made by manually.
> 4. I'm not a big fan of patch files -- instead of patching
doc/Makefile, what do you think of calling make like this: {{{make
SPHINXBUILD=sphinx-build-2.6 html}}}
I am this feeling. Your method is good. The method had been forgotten.
> 5. Why do we need config.py? To me it seemed like the auto-detection
mechanisms worked fine. If we want to use a custom config.py, we must
replace the hardcoded "/opt/local" by the value of ${prefix}.
I explain the content of config.py respectively.
bin_path
This is added to PATH for the hg command. I set for the time being
"/opt/local/bin". However, "${prefix}/bin" is better as you say.
license_path
This specifies the text displayed in the license dialog. When path is
wrong, it becomes blank.
locale_path
If this passing is correct, it comes to be able to select UI Language of
the TortoiseHG Setting dialog. I want to select the mother tongue
(Japanese).
icon_path
This specifies passing icon as well as locale_path. However, the Qt
library seems to detect the setting of default automatically.
nofork
This is the same as default.
I corrected Portfile and config.py from your questions.
--
Ticket URL: <https://trac.macports.org/ticket/28956#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list