[MacPorts] #29267: portinstall.tcl incorrectly ignores directory symlinks

MacPorts noreply at macports.org
Mon Apr 25 10:41:32 PDT 2011


#29267: portinstall.tcl incorrectly ignores directory symlinks
--------------------------------+-------------------------------------------
 Reporter:  carsomyr@…          |       Owner:  macports-tickets@…                   
     Type:  defect              |      Status:  new                                  
 Priority:  Normal              |   Milestone:                                       
Component:  base                |     Version:  1.9.2                                
 Keywords:                      |        Port:                                       
--------------------------------+-------------------------------------------
 When crawling the destroot for files to register, portinstall.tcl ignores
 directories.  Unfortunately, it also ignores symlinks that point to
 directories.  The following patch rectifies this problem:

 {{{
 --- base/src/port1.0/portinstall.tcl    (revision 78141)
 +++ base/src/port1.0/portinstall.tcl    (working copy)
 @@ -308,7 +308,7 @@
      # also save the contents for our own use later
      set installPlist {}
      fs-traverse -depth fullpath $destpath {
 -        if {[file isdirectory $fullpath]} {
 +        if {[file isdirectory $fullpath] && [file type $fullpath] !=
 "link"} {
              continue
          }
          set relpath [strsed $fullpath "s|^$destpath/||"]
 }}}

 In other words, a file is ignored iff it is a directory and NOT a symlink.

-- 
Ticket URL: <https://trac.macports.org/ticket/29267>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list