[MacPorts] #30841: pianobar @2011.07.09_0 Segmentation fault

[MacPorts]

#30841: pianobar @2011.07.09_0 Segmentation fault
----------------------------------+-----------------------------------------
 Reporter:  grrr@…                |       Owner:  aguynamedryan+pianobar@…        
     Type:  defect                |      Status:  new                             
 Priority:  Normal                |   Milestone:                                  
Component:  ports                 |     Version:  2.0.1                           
 Keywords:                        |        Port:  pianobar                        
----------------------------------+-----------------------------------------

Comment(by aguynamedryan+macports@…):

 Grrr!  Thanks for pointing me to the fix and making this an easy update
 for me!  I updated the Portfile to fetch the most recent commit from
 github.

 Just as a note, I ran into a problem while working on this patch: "sudo
 port install pianobar" would _sometimes_ fail during the destroot phase.
 Turns out that I'm running a case-insensitive file system on Mac OS X.
 There is a file named "INSTALL" in pianobar's root directory and so "make
 install" do nothing because the INSTALL file is considered up to date.
 [http://ktchu.serendipityresearch.org/research/CSE/samrai/samrai_on_mac_os_x/SAMRAI-v2.1.0
 -MACOSX-GCC4-build-notes.txt Mentioned Here]
 [http://www.ingo-
 renner.com/index.php?id=7&tx_ttnews%5Byear%5D=2005&tx_ttnews%5Bmonth%5D=09&tx_ttnews%5Bday%5D=12&tx_ttnews%5Btt_news%5D=24
 and here]

 The temporary solution is to remove the INSTALL file in the pre-destroot
 phase [https://trac.macports.org/attachment/ticket/24826/smake-1.2.1.diff
 as was done for smake at some point].

 The permanent solution, as suggested to me by dports in the #MacPorts IRC
 channel, is to add declare install to be
 [http://www.gnu.org/s/hello/manual/make/Phony-Targets.html .PHONY] in the
 Makefile like so:
 {{{
 .PHONY: install
 }}}

 This line tells make that the target "install" does not represent a file
 and so make will ignore the INSTALL file and run everytime!

 I've submitted a pull-request to the upstream maintainer to fix the
 Makefile.

 Anyway, I think this patch is ready for commit.  I've got some tunes
 streaming through pianobar 2011.07.29 as we speak!

-- 
Ticket URL: <https://trac.macports.org/ticket/30841#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS