[MacPorts] #31050: indi: installs unregistered symlinks

[MacPorts]

#31050: indi: installs unregistered symlinks
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  jtomshine@…        
     Type:  defect                   |      Status:  new                
 Priority:  Normal                   |   Milestone:                     
Component:  ports                    |     Version:  2.0.1              
 Keywords:  haspatch                 |        Port:  indi               
-------------------------------------+--------------------------------------
 indi installs symlinks that aren't registered to the port (aren't part of
 the destroot), resulting in leftovers when the port is uninstalled:

 {{{
 $ l /opt/local/bin/indi_*
 lrwxr-xr-x  1 root  wheel  32 Aug 31 00:18 /opt/local/bin/indi_lx200_16 ->
 /opt/local/bin/indi_lx200generic
 lrwxr-xr-x  1 root  wheel  32 Aug 31 00:18 /opt/local/bin/indi_lx200ap ->
 /opt/local/bin/indi_lx200generic
 lrwxr-xr-x  1 root  wheel  32 Aug 31 00:18
 /opt/local/bin/indi_lx200autostar -> /opt/local/bin/indi_lx200generic
 lrwxr-xr-x  1 root  wheel  32 Aug 31 00:18
 /opt/local/bin/indi_lx200classic -> /opt/local/bin/indi_lx200generic
 lrwxr-xr-x  1 root  wheel  32 Aug 31 00:18 /opt/local/bin/indi_lx200gps ->
 /opt/local/bin/indi_lx200generic
 lrwxr-xr-x  1 root  wheel  30 Aug 31 00:18 /opt/local/bin/indi_tcfs3_focus
 -> /opt/local/bin/indi_tcfs_focus
 $ port provides /opt/local/bin/indi_*
 /opt/local/bin/indi_lx200_16 is not provided by a MacPorts port.
 /opt/local/bin/indi_lx200ap is not provided by a MacPorts port.
 /opt/local/bin/indi_lx200autostar is not provided by a MacPorts port.
 /opt/local/bin/indi_lx200classic is not provided by a MacPorts port.
 /opt/local/bin/indi_lx200gps is not provided by a MacPorts port.
 /opt/local/bin/indi_tcfs3_focus is not provided by a MacPorts port.
 }}}

 You already noted this in comment:ticket:22132:4 but the committer
 apparently could not reproduce the issue.

 The attached patch fixes the port to register these files to itself, and
 also adds a pre-activate block to clean out leftover symlinks from
 previous versions, to prevent a conflict at activation of the new version
 of the port. This block can be removed later, once everyone has upgraded;
 one year from now would probably be a safe time to do that.

 The patch also makes indi link with libnova's dynamic library instead of
 its static library as before. I think this is the correct thing to do,
 unless you know a specific reason why the static library was being used
 before.

 If you agree with this patch, I'm happy to commit it.

-- 
Ticket URL: <https://trac.macports.org/ticket/31050>
MacPorts <http://www.macports.org/>
Ports system for Mac OS