[MacPorts] #24867: darkice is ready for Mac OSX

[MacPorts]

#24867: darkice is ready for Mac OSX
-----------------------------+----------------------------------------------
 Reporter:  nd@…             |       Owner:  macports-tickets@…                   
     Type:  submission       |      Status:  new                                  
 Priority:  Normal           |   Milestone:                                       
Component:  ports            |     Version:                                       
 Keywords:                   |        Port:  darkice                              
-----------------------------+----------------------------------------------

Comment(by ryandesign@…):

 Looks like the port behavior with its variants is mostly fine (except see
 below). I was objecting to the verbiage added to the description in
 #28320, and the behavior it implied (which the port does not exhibit
 anymore).

 If I install the port with no variants, configuration fails. jack and lame
 are default variants; if I disable them, I get:

 {{{
 sudo port -d install -- -lame -jack
 [snip]
 checking for lame library at /usr ... configure: WARNING: not found,
 building without lame
 checking for vorbis libraries at /usr ... configure: WARNING: not found,
 building without Ogg Vorbis
 checking for faac library at /usr ... configure: WARNING: not found,
 building without faac
 checking for aacplus library at /usr ... configure: WARNING: not found,
 building without aacplus
 checking for twolame library at /usr ... configure: WARNING: not found,
 building without twolame
 configure: error: neither lame, Ogg Vorbis, faac, aac+ nor twolame
 configured
 }}}

 Do all these libraries need to be variants? I realize Joshua said above
 that you could add variants, but fewer variants is better, so it would be
 simpler if the variants were deleted and the dependencies added to the
 port directly. Are any of these libraries unusual -- in that they are very
 large, take a long time to compile, provide added capability to darkice
 that hardly anybody would want? If so, then that would be a good reason to
 make it a variant. Otherwise, the port should just directly include it.

 I'm attaching a revised Portfile with these changes:

  * add modeline
  * some reformatting
  * change googlecode master_sites part to just "googlecode"
  * remove md5 checksum type (md5 is kind of obsolete)
  * remove "configure.args --mandir=${prefix}/share/man" (not needed)

 I have not yet done anything about the variants, pending your input.

-- 
Ticket URL: <https://trac.macports.org/ticket/24867#comment:21>
MacPorts <http://www.macports.org/>
Ports system for Mac OS