[MacPorts] #28161: libvirt @ 0.8.7 - new port submission

MacPorts noreply at macports.org
Sat Feb 12 22:30:32 PST 2011


#28161: libvirt @ 0.8.7 - new port submission
-------------------------------+--------------------------------------------
 Reporter:  jclift@…           |       Owner:  macports-tickets@…                   
     Type:  submission         |      Status:  new                                  
 Priority:  Normal             |   Milestone:                                       
Component:  ports              |     Version:  1.9.2                                
 Keywords:                     |        Port:  libvirt                              
-------------------------------+--------------------------------------------

Comment(by ryandesign@…):

 Why `supported_archs x86_64`? What's the matter with this port on the
 i386, ppc and ppc64 architectures?

 Your configure arguments `--with-foo=no` would be better written
 `--without-foo`.

 I see you've added a lot of variants, but actually, the fewer variants a
 port has, the better. Many of the variants you've added, you've also made
 them defaults. Is there any reason why a user would want to disable them?
 If not, remove them and just make that the unconditional behavior of the
 port. The same goes for any remaining variants that merely twiddle a
 configure argument to enable a feature; if there's no added dependency (or
 if the added dependency is small), remove the variant and just add the
 dependency to the port directly.

 What python does the python variant use? I notice it doesn't declare a
 dependency on any MacPorts python port. Most ports that have python parts
 have variants for each version of python in MacPorts. This is rather
 tedious but currently the best way.

 The docs variant sets `depends_build port:xhtml1` which overwrites the
 port's global pkgconfig build dependency; you would want to use
 `depends_build-append` in the variant instead, except that, as discussed
 above, you may want to delete the variant instead.

-- 
Ticket URL: <https://trac.macports.org/ticket/28161#comment:9>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list