[MacPorts] #28524: caml-graph @1.3 upgrade to version 1.6

MacPorts noreply at macports.org
Wed Feb 23 16:55:24 PST 2011


#28524: caml-graph @1.3 upgrade to version 1.6
-------------------------+--------------------------------------------------
 Reporter:  fh@…         |       Owner:  macports-tickets@…                   
     Type:  update       |      Status:  new                                  
 Priority:  Normal       |   Milestone:                                       
Component:  ports        |     Version:  1.9.2                                
 Keywords:  haspatch     |        Port:  caml-graph                           
-------------------------+--------------------------------------------------
Changes (by ryandesign@…):

 * cc: ryandesign@… (added)


Comment:

 Your diff is difficult to evaluate and accept. You claim your patch
 updates the port to version 1.6, but you also make all sorts of unrelated
 changes that I don't understand:

  * you remove the detailed long_description
  * you change "maintainers nomaintainer" (which is correct) to just
 "maintainers" (which is invalid)
  * you remove the slash at the end of the homepage and master_sites,
 making them uncanonical (not a major problem, but certainly less correct
 than before)
  * you move various lines around, like the distname and livecheck lines
  * you change the name of the patchfile from "patch-Makefile.in.diff" (our
 patchfile preferred format) to "patch-Makefile.in"
  * you disable the universal variant (this change is probably correct, but
 not particularly related to updating the port to 1.6, is it?)

 Perhaps you could attach a patch that ''only'' updates the port to 1.6
 (including updating the patch contents along with it, if applicable, and
 other portfile changes that directly relate to updating to 1.6). If you
 have other changes you'd like done to the port, such as reformatting, we
 could handle those separately later.

-- 
Ticket URL: <https://trac.macports.org/ticket/28524#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list