[MacPorts] #27809: openconnect @2.25 updated to @2.26

[MacPorts]

#27809: openconnect @2.25 updated to @2.26
-----------------------------------------------+----------------------------
 Reporter:  Mathias.Laurin+macports@…          |       Owner:  macports-tickets@…                   
     Type:  update                             |      Status:  new                                  
 Priority:  Normal                             |   Milestone:                                       
Component:  ports                              |     Version:                                       
 Keywords:  maintainer haspatch                |        Port:  openconnect                          
-----------------------------------------------+----------------------------

Comment(by ryandesign@…):

 Using the MacPorts base patch from #15514, I get this message when
 building your port with the patch attached to this ticket:
 {{{
 --->  Fetching openconnect
 --->  Verifying checksum(s) for openconnect
 --->  Extracting openconnect
 Warning: reinplace s|@OPTFLAGS@|-O2| didn't change anything in
 /opt/local/var/macports/build/_Users_rschmidt_macports_dports_net_openconnect/work/openconnect-2.26/Makefile
 Warning: reinplace s|@PREFIX@|/opt/local|g didn't change anything in
 /opt/local/var/macports/build/_Users_rschmidt_macports_dports_net_openconnect/work/openconnect-2.26/Makefile
 }}}
 You've removed the patchfile (which is what put "@OPTFLAGS@" and
 "@PREFIX@" into the Makefile), but retained the reinplace that replaces
 those placeholders with other things. Either the patchfile needs to stay
 and continue to put those placeholders into the Makefile, or the
 reinplaces need to go.

 It's really preferable to use a patchfile than reinplaces where possible;
 where not possible, it's often preferable to use a combination -- patch in
 a placeholder, then reinplace that placeholder with the real value (as
 this port was doing before). Having a patchfile means that if upstream
 changes their source in the future and we either need to change or remove
 our patch, we'll have enough context in the patchfile to know what we were
 thinking before and know how we need to modify things now. Therefore, I'd
 like to see some of your changes reverted -- don't convert some of the
 patchfile's functionality to reinplaces.

-- 
Ticket URL: <https://trac.macports.org/ticket/27809#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS