[MacPorts] #27652: php5, php5-devel missing suhosin patch

[MacPorts]

#27652: php5, php5-devel missing suhosin patch
-----------------------------------+----------------------------------------
  Reporter:  david@…               |       Owner:  ryandesign@…           
      Type:  defect                |      Status:  closed                 
  Priority:  Normal                |   Milestone:                         
 Component:  ports                 |     Version:  1.9.2                  
Resolution:  fixed                 |    Keywords:  suhosin                
      Port:  php5, php5-devel      |  
-----------------------------------+----------------------------------------
Changes (by ryandesign@…):

 * cc: Markus.Ueberall@… (added)
  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Replying to [comment:3 Markus.Ueberall@…]:
 > Replying to [comment:1 ryandesign@…]:
 > > Once they release a version of their patch that works with 5.3.4, I
 will be happy to update the port.
 > Luckily, an updated version of the patch is available since last year ;)

 Thanks for letting me know. I updated php5 and php5-devel with this
 information in r74780.

 > Since to my knowledge, there is not a single Linux, *BSD distribution
 which ''doesn't'' include the patch per default, may I suggest that future
 versions of the php5* ports follow suit and include a
 {{{default_variant}}} definition? (I added one in the attached patch
 {{{php5-Portfile.diff}}}.) [[br]]
 > [[br]]
 > OTOH, it could be argued that it's better to wait for 5.3.5/5.4 until
 the default is changed--in that case, "revision" doesn't necessarily need
 to be bumped.

 I was not aware that other distributions are including the suhosin patch
 by default. I am not really comfortable doing that; I would think that if
 the suhosin patch were suitable for general inclusion in php, the
 developers of php would have already done so. If you'd like to see the
 suhosin patch included in php, you should speak with the developers of php
 about that. If you'd like to further discuss the idea of making the
 suhosin variant the default, that should probably happen in another ticket
 or on the macports-users mailing list, since this ticket, which is about
 the absence of the suhosin patch for php 5.3.4, has now been resolved.

-- 
Ticket URL: <https://trac.macports.org/ticket/27652#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS