[MacPorts] #28187: simplevoc-open @1.7.0 submission ticket

[MacPorts]

#28187: simplevoc-open @1.7.0 submission ticket
-----------------------------------+----------------------------------------
 Reporter:  w.helisch@…            |       Owner:  macports-tickets@…                   
     Type:  submission             |      Status:  new                                  
 Priority:  Normal                 |   Milestone:                                       
Component:  ports                  |     Version:  1.9.2                                
 Keywords:                         |        Port:  simplevoc-open                       
-----------------------------------+----------------------------------------

Comment(by ryandesign@…):

 Some thoughts on the portfile:

  * In the post-destroot, you can dispense with creating
 ${destroot}${prefix}/etc and ${destroot}${prefix}/sbin; MacPorts has
 already created them for you.
  * "`xinstall -d`" can accept multiple directory paths per invocation.
  * "`xinstall`" can install many files from a single directory in a single
 invocation (using the "`-W`" switch).
  * Instead of "`eval xinstall ... [glob .../*.*]`" why not just "`copy`"?
  * Mac OS X does not use a directory called "lib64"; all libraries,
 regardless of architecture (and often of multiple architectures
 simultaneously, i.e. universal binaries), are in "lib".
  * You are installing a PHP module; it might be better to do this in a
 separate port, using the php5extension portgroup; see any of the existing
 portfiles in the php category. You're also not declaring a dependency on
 php5, but if you make a separate port using the php5extension portgroup,
 that detail will be taken care of for you.
  * You are modifying the php.ini. Usually in MacPorts we leave conf files
 for the user to modify, and do not modify them for the user. And in this
 case, all you're doing is adding a line to load the extension. In the
 php5extension portgroup, we create a separate .ini file for each extension
 with that kind of statement in it. And again the portgroup will do it for
 you.
  * You're installing some conf files. Their names should probably not be
 *.conf but instead *.conf.sample, so that a user can then copy the
 *.conf.sample file to *.conf and edit it. Otherwise, MacPorts would
 register the *.conf file to the port, and overwrite it at the next port
 upgrade, wiping out any customizations the user made. Some ports that deal
 with this situation just tell the user (using a "`notes`" statement) what
 file to copy where, while others do so for the user (in the post-activate
 phase), if there isn't already a conf file there.
  * You're installing your own launchd plist, then using the startupitem
 keywords to create a MacPorts launchd plist, whose sole purpose is to call
 launchctl and load your plist? No; let's just dispense entirely with the
 MacPorts startupitem stuff and just let the user use your custom plist
 directly. Possibly you may want to rename it to
 org.macports.${name}.plist, or not. We don't have many ports providing
 their own non-MacPorts plists, but you may want to see how they do it.
 avahi comes to mind, and it looks like they do not rename it.
  * You've listed the supported architectures as i686 and x86_64. i686 is
 not a valid Mac OS X architecture. The only valid architectures are i386,
 x86_64, ppc and ppc64. You are certain this software does not work on
 PowerPC computers?

-- 
Ticket URL: <https://trac.macports.org/ticket/28187#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS