[MacPorts] #29707: git-core 1.7.5.3 fails to install doc if build and destroot run as separate commands

[MacPorts]

#29707: git-core 1.7.5.3 fails to install doc if build and destroot run as separate
commands
---------------------------+------------------------------------------------
 Reporter:  mta@…          |       Owner:  macports-tickets@…                   
     Type:  defect         |      Status:  new                                  
 Priority:  Normal         |   Milestone:  MacPorts Future                      
Component:  base           |     Version:  1.9.99                               
 Keywords:                 |        Port:                                       
---------------------------+------------------------------------------------

Comment(by mta@…):

 I agree that setting things in two places is a bad idea, but that was
 already happening before my patch.  portfetch was already processing the
 various use_xxx settings but it only set extract.suffix, not the other
 extract.xxx variables.  I simply changed it to set the others.  The other
 variables were being set as a side effect of starting the extract phase.
 Yes, it's wrong to set them there too, but I didn't remove that code
 partly to keep the patch small and partly to avoid any unknown side
 effects.  Go ahead and remove the code in portextract that sets the other
 "extract.xxx" variables, it is redundant if they are set correctly when
 "use_xxx" is processed.

 It seems to me to make more sense to set all the "extract.xxx" variables
 in one place when the "use_xxx" command is processed rather than set one
 of them there and the rest when the extract phase is started (if ever).

 Are you suggesting that the default line you give above would be put in
 any port file that uses extract.cmd?  If so this seems like at least as
 error prone as my proposed fix.  Or am I not understanding what you
 intend?

-- 
Ticket URL: <https://trac.macports.org/ticket/29707#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS