[MacPorts] #29787: apache solr @ 3.2.0 - newport

MacPorts noreply at macports.org
Sun Jun 12 22:57:22 PDT 2011


#29787: apache solr @ 3.2.0 - newport
--------------------------------------+-------------------------------------
  Reporter:  hayato_1980@…            |       Owner:  ryandesign@…           
      Type:  submission               |      Status:  closed                 
  Priority:  Normal                   |   Milestone:                         
 Component:  ports                    |     Version:  1.9.2                  
Resolution:  fixed                    |    Keywords:  java search            
      Port:  apache-solr              |  
--------------------------------------+-------------------------------------
Changes (by ryandesign@…):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Committed in r79407 with some changes:

 > distfiles           ${name}-${version}.tgz

 This line is unnecessary.

 > checksums           sha1    78caf37494603d69096709ed31455e6e433bff63

 We want to use more than one checksum type. For now, we suggest sha1 and
 rmd160.

 > set extracted        ${workpath}/${name}-${version}

 This value is already available in the variable ${worksrcpath}.

 > set target           ${destroot}/${prefix}/share/java/${name}-${version}

 There should be no "/" before ${prefix}. ${prefix} already begins with a
 "/".

 >    fs-traverse -tails file ${extracted}/example { [[br]]
 >        switch -exact [ file type ${extracted}/example/${file}] { [[br]]
 >            directory { [[br]]
 >                xinstall -d -m 755 ${target}/${file} [[br]]
 >            } [[br]]
 >            file { [[br]]
 >                xinstall -m 644 ${extracted}/example/${file}
 ${target}/${file} [[br]]
 >            } [[br]]
 >        } [[br]]
 >    }

 Why not simply copy the entire directory?

 >     xinstall -m 755 ${filespath}/solr  ${prefix}/bin

 This needs to be installed into ${destroot}${prefix}/bin so that it is
 registered to the port and removed when the port is uninstalled.

 This script assumes prefix is /opt/local but it might not be. Use a
 "@PREFIX@" placeholder in the script, then reinplace that in the portfile.

 JAVA_HOME is also hardcoded into this script, and could be reinplaced from
 the portfile.

 The variable CMDNAME in this script was never used. I assume is was
 supposed to have been used in the usage message.

 > post-deactivate {} [[br]]
 > [[br]]
 > post-activate {}

 These lines are unnecessary.

-- 
Ticket URL: <https://trac.macports.org/ticket/29787#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list