[MacPorts] #28678: fossil: universal, build_arch, compiler

[MacPorts]

#28678: fossil: universal, build_arch, compiler
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  ciserlohn@…             
     Type:  defect                   |      Status:  new                     
 Priority:  Normal                   |   Milestone:                          
Component:  ports                    |     Version:  1.9.2                   
 Keywords:                           |        Port:  fossil                  
-------------------------------------+--------------------------------------

Comment(by ryandesign@…):

 Replying to [comment:3 ciserlohn@…]:
 > I left out the universal variant intentionally because i can't test the
 universal variant (no PPC machine). But otherwise it seems ok to me.

 Universal doesn't necessarily mean ppc and i386. On Snow Leopard, by
 default, it means i386 and x86_64. I verified it built ok on Snow Leopard
 for i386 and x86_64, so unless you have specific information about a build
 or runtime failure with universal on some system, we should add the
 universal variant.

 > I am not quite sure about the patch to the Makefile. Since it is
 generated by makemake.tcl it should be patched afterwards. This should be
 more robust.

 If that's the case, then it should be a patchfile for makemake.tcl.
 Patchfiles should be preferred to reinplaces, especially when there is no
 variable content that needs to be inserted at build time, and only a few
 lines of changes. I tested my patch before attaching it here, and it
 worked correctly, i.e., it made the port build with "/usr/bin/gcc-4.2"
 instead of "gcc", and the build completed. I guess that means makemake.tcl
 simply didn't regenerate the Makefile for me, perhaps because the Makefile
 was newer due to the patch?

-- 
Ticket URL: <https://trac.macports.org/ticket/28678#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS