[MacPorts] #28469: VirtualBox 4.0.4
MacPorts
noreply at macports.org
Sat Mar 26 19:41:42 PDT 2011
#28469: VirtualBox 4.0.4
--------------------------------+-------------------------------------------
Reporter: carsomyr@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 1.9.2
Keywords: | Port: VirtualBox
--------------------------------+-------------------------------------------
Changes (by ryandesign@…):
* cc: ryandesign@… (added)
Comment:
Thanks for working on this! I tried make a VirtualBox OSE port some time
ago at version 3.0.8 but got stuck on something. It'll be great to have
this in MacPorts finally.
Some thoughts on your portfile:
* We don't have a category "virtualization"; the closest we have is
"emulators".
* "openmaintainer" by itself should be "nomaintainer" (see `port lint`).
* Rather than mentioning the license in the description, use the
`license` keyword.
* Would this port work with libsdl-devel? If so, the libsdl dependency
should be written so that libsdl-devel could satisfy it. Consult most any
other port that depends on libsdl to see how this is done.
* You test build_arch in the destroot; what happens when the port is
built universal?
* If PowerPC architectures are unsupported, it would be nice to bail out
before the user has already downloaded and tried to build it. At minimum,
you should put "`supported_archs i386 x86_64`"; if that's not enough to
prevent installation on a PowerPC Mac, then a pre-fetch block should also
be there; see the wine port for an example.
* We're not used to having ports that start services just by virtue of
the port being installed. What does the startup item do when started and
stopped? Perhaps it is better to inform the user how to do this and let
them do it on their own.
* Can it be a launchd plist instead of a startup item? Startup items are
so Panther (and MacPorts doesn't support Panther anymore so there's no
reason not to use a launchd plist). If you use the standard (now misnamed)
`startupitem` keywords to create the plist, this will automatically take
care of informing the user how to use it.
--
Ticket URL: <https://trac.macports.org/ticket/28469#comment:7>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list