[MacPorts] #29020: transmission 2.22: patch phase fails with non-default MacPorts prefix

[MacPorts]

#29020: transmission 2.22: patch phase fails with non-default MacPorts prefix
------------------------------------+---------------------------------------
  Reporter:  netty.hacky@…          |       Owner:  mnick@…           
      Type:  defect                 |      Status:  closed            
  Priority:  Normal                 |   Milestone:                    
 Component:  ports                  |     Version:  1.9.2             
Resolution:  fixed                  |    Keywords:                    
      Port:  transmission           |  
------------------------------------+---------------------------------------
Changes (by ryandesign@…):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Replying to [comment:3 ryandesign@…]:
 > Confirmed, this problem exists when the MacPorts prefix is not
 /opt/local. The reason is that in the pre-patch phase, ${prefix} is
 inserted into the file being patched, and then the patchfile assumes that
 it is /opt/local that has been inserted.

 Now fixed in r78589.

 > I do not understand why this port has a pre-patch phase, a patchfile,
 and a post-patch phase, all affecting project.pbxproj. I would think that
 at most a patchfile and a post-patch reinplace would be needed.

 I've left this as-is. Turns out the pre-patch reinplace is affecting many
 many lines, so expressed as a patchfile this would be rather voluminous.

 > Note that the current patchfile isn't correct, in that it replaces
 "/opt/local/lib/libcrypto.0.9.7.dylib" with "@@PREFIX@@/libcrypto.dylib"
 when it should be replacing it with "@@PREFIX@@/lib/libcrypto.dylib".
 Curiously, the software still manages to be linked with the proper
 libcrypto; not sure how that's happening.

 Upon further investigation, I saw that this peculiarity was then undone by
 the post-patch reinplace, which replaced "@@PREFIX@@" with
 "${prefix}/lib". I've changed this in the above revision as well, so now
 "@@PREFIX@@" gets replaced with "${prefix}" as one would expect.

-- 
Ticket URL: <https://trac.macports.org/ticket/29020#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS