[MacPorts] #32149: Portfile for installing bbdb
MacPorts
noreply at macports.org
Sun Nov 20 00:23:14 PST 2011
#32149: Portfile for installing bbdb
---------------------------------+------------------------------------------
Reporter: vishketan@… | Owner: ryandesign@…
Type: submission | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version: 2.0.3
Keywords: | Port: bbdb
---------------------------------+------------------------------------------
Changes (by ryandesign@…):
* status: new => assigned
* owner: macports-tickets@… => ryandesign@…
* port: => bbdb
Comment:
Thanks. Some comments:
* The whitespace should conform to the modeline: spaces, not tabs, for
indents; you should also align things into columns -- in many Portfiles,
the 2nd column begins at the 20th character
* There should be a newline after the "`PortSystem`" line, and there
should be no trailing whitespace; see "`port lint --nitpick`"
* Since you are not a committer, the "`maintainers`" line must be your
complete valid email address, preferably in our obfuscated form
(domain:user)
* More than one checksum type should be used for each distfile; rmd160
and sha256 are recommended
* The checksum you supplied doesn't match the checksum of the file
MacPorts downloaded for me; the file hasn't changed on SourceForge since
2007 so I'm not sure what file's checksum you listed; I'll change it to
the checksums I'm getting
* The "`--prefix`" argument goes in configure.pre_args, not
configure.args
* Instead of "`ui_msgs`" in post-activate, use "`notes`"
* SourceForge master_sites should be written more specifically, to avoid
redirects
* "`distname bbdb-${version}`" is the default, so it's redundant
* The descriptions of variants should be worded as if they were checkbox
or radio button labels
* Files should be installed with permission so that regular users can
read them (644 instead of 640)
--
Ticket URL: <https://trac.macports.org/ticket/32149#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list