[MacPorts] #32304: openconnect new version 3.15 - portfile update

[MacPorts]

#32304: openconnect new version 3.15 - portfile update
--------------------------------+-------------------------------------------
  Reporter:  florian@…          |       Owner:  ryandesign@…           
      Type:  update             |      Status:  closed                 
  Priority:  Normal             |   Milestone:                         
 Component:  ports              |     Version:  2.0.3                  
Resolution:  fixed              |    Keywords:  haspatch               
      Port:  openconnect        |  
--------------------------------+-------------------------------------------

Comment(by florian@…):

 Replying to [comment:4 ryandesign@…]:
 > >  * textproc/aspell
 >
 > The aspell port says:
 > {{{
 > platform macosx {
 > # gnustep-gui uses aspell and will not work if aspell is linked to
 gettext because
 > # gettext is linked to CoreFoundation which is itself linked to the
 Apple objc runtime
 >     if { ![variant_isset nls] } {
 >         default_variants        +nonls
 >     }
 > }
 > }}}
 > so it sounds like it's not a good idea to enable nls for aspell.
 >
 > >  * x11/icewm
 >
 > The description of the variant there says "Use internationalized
 messages (does not work correct yet)" so I don't think it's a good idea to
 enable nls for icewm.

 Sorry, I just grepped the portfiles for nls variants and did not check any
 details.

 > > Btw, are there any guidelines for creating variants and when not to do
 so? Thanks for the quick update!
 >
 > Ports should usually include as much functionality as possible without
 the need to select variants. Make a variant if the feature is esoteric
 (i.e. few users would want it), or has undesirable side effects, or has
 many dependencies or large dependencies that take a long time to build.
 gettext is an extremely common library that will almost definitely be on
 all users' systems already. (gettext is a library dependency of glib2,
 which is a library dependency of pkgconfig, which is a build dependency of
 a majority of ports (including openconnect)).

 Right, the argumentation makes sense. On the other hand, it seems to be a
 matter of personal taste where to draw the line. Btw: there are bzip2
 variants, even though bzip2 is probably more common than gettext and
 unlike gettext has no dependencies at all.

-- 
Ticket URL: <https://trac.macports.org/ticket/32304#comment:5>
MacPorts <http://www.macports.org/>
Ports system for Mac OS