[MacPorts] #30385: new port: R-framework

[MacPorts]

#30385: new port: R-framework
---------------------------------+------------------------------------------
 Reporter:  kjell.konis@…        |       Owner:  macports-tickets@…                   
     Type:  submission           |      Status:  new                                  
 Priority:  Normal               |   Milestone:                                       
Component:  ports                |     Version:                                       
 Keywords:                       |        Port:  R-framework                          
---------------------------------+------------------------------------------

Comment(by kjell.konis@…):

 I just attached an updated Portfile that (I hope) addresses all of these
 points. Thanks.

 Replying to [comment:9 ryandesign@…]:
 > Some comments:
 >
 >  * Is pkgconfig really a library dependency? Usually it's only needed at
 build time.
 >  * The reinplace you're doing in a post-extract block should be in a
 post-patch block instead. You want to be able to "sudo port extract
 R-framework" and see the pristine extracted files. This change should be
 made to R as well.
 >  * MacPorts adds the --prefix argument in configure.pre_args for you. If
 you want to change it, overwrite configure.pre_args instead of adding
 --prefix to configure.args.
 >  * In the cairo variant, the cairo, pango and glib2 dependencies should
 be written such that cairo-devel, pango-devel and glib2-devel,
 respectively, could satisfy them as well. Consult other ports that depend
 on these ports for examples (including even your R port).
 >  * In the post-destroot block, when you "xinstall
 ${destroot}${frameworks_dir}/lib/pkgconfig/libR.pc
 ${destroot}${prefix}/lib/pkgconfig", that will use the default permissions
 of 755, but pkgconfig .pc files do not need the execute bit, so you should
 specify -m 644 when you xinstall. Or even easier, why not just move the
 file, instead of copying it, then deleting it? You also don't need to
 manually delete empty directories; MacPorts will delete empty directories
 for you after destroot.
 >  * The symbolic links you're creating with ln are pointing into the
 destroot, which you don't want.

-- 
Ticket URL: <https://trac.macports.org/ticket/30385#comment:10>
MacPorts <http://www.macports.org/>
Ports system for Mac OS