[MacPorts] #31650: rose @0.9.5a

[MacPorts]

#31650: rose @0.9.5a
---------------------------+------------------------------------------------
 Reporter:  too1@…         |       Owner:  macports-tickets@…                   
     Type:  submission     |      Status:  new                                  
 Priority:  Normal         |   Milestone:                                       
Component:  ports          |     Version:  2.0.3                                
 Keywords:  maintainer     |        Port:  rose                                 
---------------------------+------------------------------------------------

Comment(by ryandesign@…):

 Thanks. Some comments:

  * Your email address should be obfuscated in the maintainers line:
 `llnl.gov:too1`.
  * The license should be just "`BSD`".
  * Please fetch from an official distfile. If none is available, fetch
 from the specific repository revision or branch that represents version
 0.9.5a. Fetching from HEAD is not predictable.
  * When `fetch.type` is "`git`", MacPorts adds git-core as a fetch
 dependency for you; you don't need to add it manually.
  * The dependency on graphviz should be written so that graphviz-devel
 could satisfy it; see other ports that depend on graphviz for examples of
 how this is done, or #14540.
  * I notice the build dependency on wget... Does this software really use
 wget to fetch things during its build? Ports should not be fetching things
 during the build phase; they should fetch all necessary files during the
 fetch phase, if possible.
  * "`gcc`" is not a valid value for `configure.compiler`; you seem to want
 `configure.compiler macports-gcc-4.4`. Then, where you hardcode
 `${prefix}/bin/gfortran-mp-4.4`, you can replace that with
 `${configure.fc}`. And you can add compiler variants to give users a
 choice. See PortfileRecipes.
  * You probably shouldn't set `build.jobs` to `0`, thereby overriding the
 user's choice of number of build jobs.
  * Note that `system` now has a `-W` argument that you can use instead of
 manually cd'ing into a directory: `system -W ${worksrcpath} "./build"`

-- 
Ticket URL: <https://trac.macports.org/ticket/31650#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS