[MacPorts] #31096: Email produced by editing revision properties has faulty headers, requires moderation

[MacPorts]

#31096: Email produced by editing revision properties has faulty headers, requires
moderation
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  wsiegrist@…        
     Type:  defect                   |      Status:  new                
 Priority:  Normal                   |   Milestone:                     
Component:  server/hosting           |     Version:                     
 Keywords:                           |        Port:                     
-------------------------------------+--------------------------------------
 We have some problem lately with editing commit messages after the fact.
 It used to work fine, but now when I run something like this:

 {{{
 svn propedit --revprop -r 83473
 }}}

 ...and enter and save a new commit message, I get this email reply:

 {{{
 From: macports-changes-bounces at lists.macosforge.org
 Date: September 3, 2011 18:25:19 CDT
 To: ryandesign at macports.org
 Subject: Your message to macports-changes awaits moderator approval

 Your mail to 'macports-changes' with the subject

    (no subject)

 Is being held until the list moderator can review it for approval.

 The reason it is being held:

    Message has implicit destination

 Either the message will get posted to the list, or you will receive
 notification of the moderator's decision.  If you would like to cancel
 this posting, please visit the following URL:

    http://lists.macosforge.org/mailman/confirm.cgi/macports-
 changes/53284e8b06c692020b1884d5f76189564e8c6bff
 }}}

 Then the mailing list management (including me) gets this message:

 {{{
 From: macports-changes-owner at lists.macosforge.org
 Date: September 3, 2011 18:25:19 CDT
 To: macports-changes-owner at lists.macosforge.org
 Subject: macports-changes post from ryandesign at macports.org requires
 approval

 As list administrator, your authorization is requested for the
 following mailing list posting:

    List:    macports-changes at lists.macosforge.org
    From:    ryandesign at macports.org
    Subject: (no subject)
    Reason:  Message has implicit destination

 At your convenience, visit:

    http://lists.macosforge.org/mailman/admindb.cgi/macports-changes

 to approve or deny the request.

 From: ryandesign at macports.org
 Date: September 3, 2011 18:25:18 CDT
 To: undisclosed-recipients: ;


 From ryandesign at macports.org Sat Sep  3 16: 26:26 2011
 Date: Sat, 03 Sep 2011 16:26:26 -0700
 To: macports-changes at lists.macosforge.org
 From: ryandesign at macports.org
 Subject: propchange - r83473 svn:log
 Reply-to: macports-dev at lists.macosforge.org, ryandesign at macports.org

 Author: ryandesign at macports.org (original author:
 macsforever2000 at macports.org)
 Revision: 83473
 Property Name: svn:log

 @@ -1 +1 @@
 -hatari: Update to version 1.5.0. Change to nomaintainer. (#31074)
 +hatari: Update to version 1.5.0 (#31074)




 From: macports-changes-request at lists.macosforge.org
 Date: September 3, 2011 18:25:19 CDT
 Subject: confirm 53284e8b06c692020b1884d5f76189564e8c6bff


 If you reply to this message, keeping the Subject: header intact,
 Mailman will discard the held message.  Do this if the message is
 spam.  If you reply to this message and include an Approved: header
 with the list password in it, the message will be approved for posting
 to the list.  The Approved: header can also appear in the first line
 of the body of the reply.
 }}}

 Finally, when I log in and approve the message, it gets delivered:

 {{{
 From: ryandesign at macports.org
 Date: September 3, 2011 18:25:18 CDT
 To: undisclosed-recipients: ;

 From ryandesign at macports.org Sat Sep  3 16: 26:26 2011
 Date: Sat, 03 Sep 2011 16:26:26 -0700
 To: macports-changes at lists.macosforge.org
 From: ryandesign at macports.org
 Subject: propchange - r83473 svn:log
 Reply-to: macports-dev at lists.macosforge.org, ryandesign at macports.org

 Author: ryandesign at macports.org (original author:
 macsforever2000 at macports.org)
 Revision: 83473
 Property Name: svn:log

 @@ -1 +1 @@
 -hatari: Update to version 1.5.0. Change to nomaintainer. (#31074)
 +hatari: Update to version 1.5.0 (#31074)

 _______________________________________________
 macports-changes mailing list
 macports-changes at lists.macosforge.org
 http://lists.macosforge.org/mailman/listinfo.cgi/macports-changes
 }}}

 This has happened with recent revprop changes by me, Jeremy Lavergne, and
 Bryan Blackburn, so it's not an isolated incident.

 There's some problem with the headers of the message that the server is
 sending in response to commit changes. The "header" "`From
 ryandesign at macports.org Sat Sep  3 16: 26:26 2011`" is obviously strange
 in a couple ways, and it has a blank line before it, making all the
 subsequent lines not be seen as headers by the mailing software.

 Has anything changed about the repository's post-revprop-change hook
 script lately, or has the mailing library it's using been upgraded to a
 newer version?

-- 
Ticket URL: <https://trac.macports.org/ticket/31096>
MacPorts <http://www.macports.org/>
Ports system for Mac OS