[MacPorts] #31324: live555 copies entire worksrcdir into destroot

MacPorts noreply at macports.org
Thu Sep 22 22:50:33 PDT 2011


#31324: live555 copies entire worksrcdir into destroot
--------------------------------------+-------------------------------------
  Reporter:  ryandesign@…             |       Owner:  milosh@…           
      Type:  defect                   |      Status:  closed             
  Priority:  Normal                   |   Milestone:                     
 Component:  ports                    |     Version:                     
Resolution:  fixed                    |    Keywords:  haspatch           
      Port:  live555                  |  
--------------------------------------+-------------------------------------
Changes (by ryandesign@…):

  * status:  new => closed
  * keywords:  => haspatch
  * resolution:  => fixed


Comment:

 Thanks, that looks pretty good. I committed a modified version in r84348.
 I made these changes:

  * I generated the "before" list in post-configure instead of post-patch.
 That way, the Makefiles the configure process generates aren't considered
 new files and we don't have to delete them separately later.
  * Instead of deleting items from the build directory in post-build, I
 deleted them in the destroot. This is more like how other ports' destroot
 phases work, and it will be more familiar to other port builders who might
 expect to see an intact build directory.
  * I changed the `ui_msg`s to `ui_debug`s so they don't show up in the
 normal output.
  * I used `find`'s `-s` argument instead of piping to a separate `sort`
 process.

-- 
Ticket URL: <https://trac.macports.org/ticket/31324#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list