[MacPorts] #34017: par mangles UTF-8 input with a non-breaking space character U+00A0

MacPorts noreply at macports.org
Tue Apr 17 06:53:16 PDT 2012


#34017: par mangles UTF-8 input with a non-breaking space character U+00A0
----------------------------+-----------------------------------------------
 Reporter:  kenh@…          |       Owner:  qbarnes@…        
     Type:  defect          |      Status:  new              
 Priority:  Normal          |   Milestone:                   
Component:  ports           |     Version:  2.0.4            
 Keywords:  haspatch        |        Port:  par              
----------------------------+-----------------------------------------------

Comment(by ryandesign@…):

 Replying to [comment:7 qbarnes@…]:
 > Ryan, did you look at the lines I deleted from the Portfile,
 specifically the "reinplace" line? [[br]]
 > [[br]]
 > What I did was move the functionality of the reinplace line into a
 protoMakefile patch file.

 I agree that the CFLAGS lines of the new patchfile are functionally
 equivalent to the old reinplace. I just maintain that neither are
 necessary.

 > Adding CFLAGS to the makefile dates back to 2004 when I first added the
 package.  One of the maintainers back then required the addition.  (I
 looked for the mail and couldn't find it.)  Is having makefiles be able to
 pick up CFLAGS from the environment no longer necessary or desired?

 Having Makefiles be able to support CFLAGS, CPPFLAGS, LDFLAGS, CC, CXX etc
 variables is greatly desirable, and if this port were still being
 developed by its developer I would recommend you send the patch to them.
 But this port does not use the CFLAGS, CPPFLAGS, LDFLAGS variables so
 there's no point in doing this within MacPorts. MacPorts itself only
 supplies these variables when it runs a standard configure script, which
 this port does not have. We might be interested in manually supplying the
 CFLAGS, CPPFLAGS, LDFLAGS variables to the Makefile if par required that
 to help it link with other software, but par doesn't appear to link with
 any other software so that's not necessary.

 > The maintainer back then helped me come up with the reinplace line so I
 could avoid having to make a patch file for the makefile.  Since I already
 now had other patch files, I no longer saw its benefit and just moved the
 change to the patch.

 Indeed, when portfile variables are not involved, a patchfile is greatly
 preferable to a reinplace.

 > If you notice, for the FreeBSD changes to par
 (http://www.freebsd.org/cgi/cvsweb.cgi/ports/textproc/par/files/), they
 also modify the makefile to pick up CFLAGS.  Since darwinports was based
 on BSD's ports, is it an old requirement?

 [wiki:MacPortsHistory MacPorts was inspired by FreeBSD ports], but is
 written in a different language than FreeBSD ports and doesn't share any
 code with FreeBSD ports. I am not familiar with how FreeBSD ports works or
 how it uses the CFLAGS etc. variables. Presumably FreeBSD ports actually
 sets the CFLAGS variable to something at build time, and it wants the par
 port's Makefile to pick that up.

-- 
Ticket URL: <https://trac.macports.org/ticket/34017#comment:8>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list