[MacPorts] #30061: NEW: hplip @3.11.5
MacPorts
noreply at macports.org
Sun Apr 29 17:33:01 PDT 2012
#30061: NEW: hplip @3.11.5
--------------------------------------+-------------------------------------
Reporter: okmacports@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 1.9.2
Keywords: | Port: hplip
--------------------------------------+-------------------------------------
Comment(by jmr@…):
First of all:
{{{
% port lint
---> Verifying Portfile for hplip
Error: Missing required variable: homepage
Warning: Variant gui does not have a description
Warning: Maintainer email address should be obfuscated as
johnfreed.com:okmacports
Warning: no license set
---> 1 errors and 3 warnings found.
}}}
Other comments on the portfile:
* Revision should start at 0 (this is the default value).
* configure.ldflags already contains the value that is being appended.
* -I flags should normally go in configure.cppflags, unless the build
system ignores the CPPFLAGS variable. configure.cppflags contains
-I${prefix}/include by default.
* The gui variant depends on a nonexistent port "PyQt". It also depends
on py-readline and py-reportlab, which are for python 2.4, whereas the
python_version variable and the dbus-python27 dependency from earlier
indicate that 2.7 is intended to be used. Using `/usr/bin/env pythonw` in
the scripts is also incorrect as the first pythonw in the user's path has
no guarantee of being the one in which the dependencies are installed.
* You can pass multiple files to a single reinplace call.
* Editing config files isn't something ports normally do, since not all
users will want it. If it should happen in this case, it should probably
happen in post-activate.
* Creating symlinks directly in the installed location in post-install is
incorrect, as they won't be removed when the port is uninstalled. If you
can't install to the correct location in the first place, create the
symlinks in the destroot.
--
Ticket URL: <https://trac.macports.org/ticket/30061#comment:13>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list