[MacPorts] #37328: nethack @3.4.3 +x11 Build failure

[MacPorts]

#37328: nethack @3.4.3 +x11 Build failure
------------------------+--------------------------------
 Reporter:  nurblieh@…  |      Owner:  macports-tickets@…
     Type:  defect      |     Status:  new
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.1.2
 Keywords:              |       Port:
------------------------+--------------------------------
 nethack with the x11 variant selecetd fails to build, as the X11 headers
 can not be found.

 The bug is that the build.args-appends directive in the Portfile overrides
 the Makefile's CFLAGS that the x11 variant patches in.

 Removing the build.args-apend directive from the Portfile fixes the issue
 and is, largely unnecessary. (O vs O2 though...)

 This is from the x11 Makefile patch,
 {{{
 -CFLAGS = -O -I../include
 +CFLAGS = -O -I../include -I/usr/X11R6/include
 }}}
 This is what exists in build.args-append,
 {{{
 build.args-append       CFLAGS="-O2 -I../include"
 }}}

 So the {{{-I/usr/X11R6/include}}} never gets respected.

 Attached is a working diff.

 Xcode 4.4; Mac OS X 10.8.2

-- 
Ticket URL: <https://trac.macports.org/ticket/37328>
MacPorts <http://www.macports.org/>
Ports system for Mac OS