[MacPorts] #33315: libzzip: universal variant fails with clang

[MacPorts]

#33315: libzzip: universal variant fails with clang
-------------------------------------+--------------------------------------
 Reporter:  david.reitter@…          |       Owner:  ryandesign@…           
     Type:  defect                   |      Status:  assigned               
 Priority:  Normal                   |   Milestone:                         
Component:  ports                    |     Version:  2.0.3                  
 Keywords:  clang universal          |        Port:  libzzip                
-------------------------------------+--------------------------------------
Changes (by ryandesign@…):

  * status:  new => assigned
  * owner:  macports-tickets@… => ryandesign@…


Comment:

 The problem is that we fix the `--export-dynamic` problem like this:

 {{{
 post-patch {
     reinplace {/ZZIPLIB_LDFLAGS=/s/--export-dynamic/-export-dynamic/} \
         ${worksrcpath}/configure
 }
 }}}

 But when the universal variant is selected we do this:

 {{{
 if {[variant_isset universal]} {
     patchfiles-append patch-configure.ac.diff
     use_autoconf yes
 }
 }}}

 This causes autoconf to run, thus regenerating configure from configure.ac
 and wiping out what we did in our reinplace.

 It would be simplest if we get rid of the reinplace and turn it into a
 patch-configure.diff, and also add the patch to the existing patch-
 configure.ac.diff for when the universal variant is used.

-- 
Ticket URL: <https://trac.macports.org/ticket/33315#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS