[MacPorts] #35171: mogenerator Portfile

MacPorts noreply at macports.org
Thu Jul 12 09:34:58 PDT 2012


#35171: mogenerator Portfile
-----------------------------------------+----------------------------------
 Reporter:  public@…                     |       Owner:  macports-tickets@…                   
     Type:  submission                   |      Status:  new                                  
 Priority:  Normal                       |   Milestone:                                       
Component:  ports                        |     Version:  2.1.1                                
 Keywords:                               |        Port:  mogenerator                          
-----------------------------------------+----------------------------------

Comment(by public@…):

 >  * Delete the name and version lines; that's part of what the
 github.setup line does for you automatically
 >  * As "port lint" will tell you, the maintainers line should be
 obfuscated (host:user)
 >  * As "port lint" will tell you, "configure {}" should be changed to
 "use_configure no"
 >  * As "port livecheck" will tell you, "git" is not a valid
 livecheck.type
 >  * Please change the whitespace of the portfile to conform to the
 modeline (indentations at multiples of 4 spaces)
 >  * Have you considered using the xcode portgroup?

 done

 I guess the "lint" part should be mentioned on the docs?
 http://guide.macports.org/chunked/project.contributing.html

 >  * Does this port really use git-core at build time and at runtime?

 The port only needs git-core for cloning out of github, but because of
 your comment I assume that the github porgroup also takes care of that

 I have just attached Portfile.2 to the ticket

 There is also one extra modification I made, which should not be a big
 deal. In the first line, along the Vim parameters I set the portfile
 syntax as filetype, and not "tcl"

-- 
Ticket URL: <https://trac.macports.org/ticket/35171#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list