[MacPorts] #35316: frotz doesnt build under lion

[MacPorts]

#35316: frotz doesnt build under lion
-------------------------------------+--------------------------------------
 Reporter:  robert.cohen@…           |       Owner:  pack-darwinports@…         
     Type:  defect                   |      Status:  new                        
 Priority:  Normal                   |   Milestone:                             
Component:  ports                    |     Version:  2.1.1                      
 Keywords:  haspatch                 |        Port:  frotz                      
-------------------------------------+--------------------------------------
Changes (by ryandesign@…):

  * keywords:  => haspatch
  * owner:  macports-tickets@… => pack-darwinports@…
 * cc: ryandesign@… (added)


Old description:

> The package frotz no longer builds under lion.
> It appears the function getline now clashes with a MacOS function.
> Should be a trivial patch to rename the getline function to something
> like getline_local.
>
> The build error log is
>
> :info:build src/dumb/dumb_input.c:83: error: conflicting types for
> ‘getline’
> :info:build /usr/include/stdio.h:449: error: previous declaration of
> ‘getline’ was here
> :info:build src/dumb/dumb_input.c: In function ‘dumb_read_line’:
> :info:build src/dumb/dumb_input.c:263: warning: field precision should
> have type ‘int’, but argument 2 has type ‘long int’
> :info:build src/dumb/dumb_input.c:263: warning: field precision should
> have type ‘int’, but argument 2 has type ‘long int’
> :info:build make: *** [src/dumb/dumb_input.o] Error 1

New description:

 The package frotz no longer builds under lion.
 It appears the function getline now clashes with a MacOS function.
 Should be a trivial patch to rename the getline function to something like
 getline_local.

 The build error log is

 {{{
 :info:build src/dumb/dumb_input.c:83: error: conflicting types for
 ‘getline’
 :info:build /usr/include/stdio.h:449: error: previous declaration of
 ‘getline’ was here
 :info:build src/dumb/dumb_input.c: In function ‘dumb_read_line’:
 :info:build src/dumb/dumb_input.c:263: warning: field precision should
 have type ‘int’, but argument 2 has type ‘long int’
 :info:build src/dumb/dumb_input.c:263: warning: field precision should
 have type ‘int’, but argument 2 has type ‘long int’
 :info:build make: *** [src/dumb/dumb_input.o] Error 1
 }}}

--

Comment:

 Agreed. Here is a patch. Bruce, may I commit it?

 P.S: Robert, please use WikiFormatting when writing in Trac.

-- 
Ticket URL: <https://trac.macports.org/ticket/35316#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS