[MacPorts] #35018: metis: update to 5.0.2

[MacPorts]

#35018: metis: update to 5.0.2
-----------------------------+----------------------------------------------
 Reporter:  zan@…            |       Owner:  ryandesign@…           
     Type:  update           |      Status:  assigned               
 Priority:  Normal           |   Milestone:                         
Component:  ports            |     Version:  2.1.1                  
 Keywords:  haspatch         |        Port:  metis                  
-----------------------------+----------------------------------------------
Changes (by ryandesign@…):

  * status:  new => assigned
  * owner:  macports-tickets@… => ryandesign@…


Comment:

 Thanks for the update!

 Clemens: Clearing configure.pre_args and configure.universal_args is fine
 and necessary for some non-autoconf configure scripts; this configure
 script isn't even a configure script—it's `make`—so clearing those
 variables is right and good in this situation.

 Often in these cases we'd still need to manually handle -arch flags, like
 the previous version of the port did. But cmake appears to be handling it
 correctly based only on the environment variables MacPorts passes at
 configure time. So everything's fine there.

 Clearing variables is usually done by listing the variable name with no
 value after it, not by listing the value {}.

 Setting build.cmd and destroot.cmd to /usr/bin/make is not necessary
 because that is the default. And instead of clearing build.args and
 build.pre_args, usually you would clear build.target—like the previous
 version of the Portfile did. I see however that it's having problems with
 the "-w" argument that MacPorts base now adds to build.pre_args. I'm not
 real clear on why "-w" was added to the default build.pre_args
 (documentation for "-w" says you usually don't need to add it manually),
 nor why "-w" is getting translated to "w" somewhere within metis' build
 system. But the "-w" argument appears to be the only problem, and setting
 (build|destroot).pre_args back to just (build|destroot).target, like it
 was in older versions of MacPorts, works.

 You've added our standard modeline, which is good, but while you've made
 some whitespace changes, the whitespace does not conform to what the
 modeline says. The standard modeline should only be added if the port's
 whitespace already conforms to it, or if in the same commit you make the
 whitespace conform. In particular this means using spaces, at four spaces
 per indent, instead of tabs.

 You removed a comment which explained why we were taking the unusual step
 of deleting -L${prefix}/lib from configure.ldflags. That comment should be
 retained, if indeed that line is still needed and still performs that
 function. Rather, I guess since the build system has totally changed (to
 cmake) that this line isn't necessary anymore and can be removed along
 with the comment.

 The openmpi variant you added needs to conflict with the universal
 variant, because the openmpi port does not have a universal variant. I
 can't test this variant further because I can't build openmpi (#34302).

-- 
Ticket URL: <https://trac.macports.org/ticket/35018#comment:5>
MacPorts <http://www.macports.org/>
Ports system for Mac OS