[MacPorts] #32837: new portfile for RKWard

MacPorts noreply at macports.org
Sat Mar 3 12:04:51 PST 2012


#32837: new portfile for RKWard
----------------------------------------------+-----------------------------
 Reporter:  meik.michalke@…                   |       Owner:  macports-tickets@…                   
     Type:  submission                        |      Status:  new                                  
 Priority:  Normal                            |   Milestone:                                       
Component:  ports                             |     Version:  2.0.3                                
 Keywords:                                    |        Port:                                       
----------------------------------------------+-----------------------------

Comment(by ryandesign@…):

 Some comments:

  * We can't accept a port that fetches its sources directly from svn
 trunk. Please use a specific svn.revision. Probably that revision, or its
 corresponding date, should then be a part of the port's advertised
 version, something like "version 0.5.7-${svn.revision}". The plus sign
 should probably never appear in the version field; it would probably cause
 problems since that's the symbol we use to request variants.
  * In the pre-configure block, there's no need to use "system" to make a
 directory. Just use the "file mkdir" tcl command. You probably also want
 to do this at post-extract instead of pre-configure, so that, if the
 configure fails for some reason and the user retries it, you won't be
 trying to create a directory that already exists.
  * Since you're using cmake to configure this port, have you considered
 using the cmake portgroup? It might simplify things. It would, for one
 thing, add the required build-time dependency on cmake that you're
 currently lacking.

-- 
Ticket URL: <https://trac.macports.org/ticket/32837#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list