[MacPorts] #33627: pgplot: add gcc46 variant (was: pgplot does not have a gcc46 variant)

MacPorts noreply at macports.org
Wed Mar 14 18:49:06 PDT 2012


#33627: pgplot: add gcc46 variant
--------------------------------------------+-------------------------------
 Reporter:  russell.jones@…                 |       Owner:  ryandesign@…           
     Type:  enhancement                     |      Status:  assigned               
 Priority:  Normal                          |   Milestone:                         
Component:  ports                           |     Version:  2.0.4                  
 Keywords:  haspatch                        |        Port:  pgplot                 
--------------------------------------------+-------------------------------
Changes (by ryandesign@…):

  * status:  new => assigned
  * owner:  macports-tickets@… => ryandesign@…
  * type:  defect => enhancement
  * keywords:  => haspatch


Comment:

 In the future please provide a unified diff of your changes instead of a
 complete new Portfile; this will make it easier for us to review your
 changes.

 The line "build.env-append      F77=${fc} F90=${fc}" that you added to the
 gcc43 variant does not belong; it breaks that variant.

 Your've also changed the whitespace of some of the lines. While I agree
 with changing the port's whitespace because it is currently a mix of tabs
 and spaces at 2-space multiples, neither of which conforms to the modeline
 which says the port uses multiple-of-4-space indents, whitespace changes
 should be made separately from functional changes.

-- 
Ticket URL: <https://trac.macports.org/ticket/33627#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list