[MacPorts] #26074: update zim
MacPorts
noreply at macports.org
Thu Mar 22 19:47:58 PDT 2012
#26074: update zim
-------------------------------+--------------------------------------------
Reporter: bassliu@… | Owner: macports-tickets@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: | Port: zim
-------------------------------+--------------------------------------------
Comment(by macsforever2000@…):
A couple of comments. If you package up your changes in an archive, it's
less likely to get reviewed. It is best to attach the individual files
unless there are lots of them, which is not the case. Also, unified diffs
of the existing portfile are preferred and also increase the chances of
getting your changes looked at and committed.
About the actual changes:
1. The revision line needs to be removed.
1. Your email should be obfuscated like "ualberta.ca:burkhard"
1. The md5 and sha1 checksums should be removed and a sha256 added.
1. I'm not sure why you are using a python portgroup because that is
used for python modules. Is this a python module? If so, it should be
called py-zim. You should not be using the python2.6 portgroup. Use the
unified python 1.0 portgroup and subports instead.
1. You should allow different versions of python to be used and have
python 2.7 be the default. Either add python variants for python26,
python27, etc. or make subports called py26-zim, py27-zim etc. if this is
a python module.
--
Ticket URL: <https://trac.macports.org/ticket/26074#comment:10>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list