[MacPorts] #34352: mercurial: reinplace didn't change anything in setup.py

[MacPorts]

#34352: mercurial: reinplace didn't change anything in setup.py
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  deric@…           
     Type:  defect                   |      Status:  new               
 Priority:  Normal                   |   Milestone:                    
Component:  ports                    |     Version:  2.0.4             
 Keywords:                           |        Port:  mercurial         
-------------------------------------+--------------------------------------
 When installing mercurial with a MacPorts that has been patched as per
 #15514, I see:

 {{{
 Warning: reinplace s/-arch i386 -arch x86_64/-arch x86_64 -arch i386/
 didn't change anything in
 /opt/local/var/macports/build/_Users_rschmidt_macports_dports_devel_mercurial/mercurial/work/mercurial-2.2.1/setup.py
 }}}

 So that reinplace can be removed.

 Examining setup.py, I see this code:

 {{{
 if sys.platform == 'darwin' and os.path.exists('/usr/bin/xcodebuild'):
     # XCode 4.0 dropped support for ppc architecture, which is hardcoded
 in
     # distutils.sysconfig
     version = runcmd(['/usr/bin/xcodebuild', '-version'],
 {})[0].splitlines()
     if version:
         version = version[0]
         xcode4 = (version.startswith('Xcode') and
                   StrictVersion(version.split()[1]) >=
 StrictVersion('3.0'))
     else:
         # xcodebuild returns empty on OS X Lion with XCode 4.3 not
         # installed, but instead with only command-line tools. Assume
         # that only happens on >= Lion, thus no PPC support.
         xcode4 = True

     if xcode4:
         os.environ['ARCHFLAGS'] = ''
 }}}

 I'm not terribly familiar with how python builds, but if this is doing
 what it looks like—removing all `-arch` flags when the Xcode version is
 4.0 or greater—then that's not something we want it to be doing, and we
 might want to patch setup.py to completely remove the above lines.

-- 
Ticket URL: <https://trac.macports.org/ticket/34352>
MacPorts <http://www.macports.org/>
Ports system for Mac OS