[MacPorts] #34505: port cmake pkg-config broken on 2.8.8

[MacPorts]

#34505: port cmake pkg-config broken on 2.8.8
---------------------------+----------------------
  Reporter:  and.damore@…  |      Owner:  css@…
      Type:  defect        |     Status:  closed
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.1.0
Resolution:  fixed         |   Keywords:  haspatch
      Port:  cmake         |
---------------------------+----------------------
Changes (by and.damore@…):

 * status:  reopened => closed
 * resolution:   => fixed


Old description:

> As per [http://www.cmake.org/Bug/print_bug_page.php?bug_id=13125 this bug
> report] cmake 2.8.8 introduced an error, the expecting PKG_CONFIG_FOUND
> variable is not set when the package is found.
> This can be reproduced building port avidemux whose cmake configuration
> halts printing bot "found pkg-config" and "pkg-config not found".
>
> I'm attaching patch.

New description:

 As per [http://www.cmake.org/Bug/print_bug_page.php?bug_id=13125 this bug
 report] cmake 2.8.8 introduced an error, the expecting PKG_CONFIG_FOUND
 variable is not set when the package is found.
 This can be reproduced building port avidemux whose cmake configuration
 halts printing out "found pkg-config" and "pkg-config not found".

 I'm attaching patch.

--

Comment:

 Replying to [comment:3 help@…]:
 > cmake version was bumped in Portfile, but this patch wasn't dropped. In
 result pkg-config support in cmake broke. Please revert this change.
 Tested using local overlay, removing patch-
 Modules_FindPkgConfig_cmake.diff from patchfiles works.

 This ticket was correctly closed, you should have raised the point in
 #35882 that updated '''cmake''' in r97601, please continue discussion
 there.

-- 
Ticket URL: <https://trac.macports.org/ticket/34505#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS