[MacPorts] #38626: oracle-instantclient: set rpath instead of advising users to set DYLD_LIBRARY_PATH

[MacPorts]

#38626: oracle-instantclient: set rpath instead of advising users to set
DYLD_LIBRARY_PATH
-----------------------------------+--------------------------
  Reporter:  dluke@…               |      Owner:  ryandesign@…
      Type:  enhancement           |     Status:  assigned
  Priority:  Normal                |  Milestone:
 Component:  ports                 |    Version:  2.1.3
Resolution:                        |   Keywords:
      Port:  oracle-instantclient  |
-----------------------------------+--------------------------
Changes (by ryandesign@…):

 * status:  new => assigned
 * type:  defect => enhancement


Comment:

 Thanks for filing this ticket. Yes absolutely if there is a way to avoid
 requiring users to set DYLD_LIBRARY_PATH then we should do that. But
 setting DYLD_LIBRARY_PATH is what Oracle says to do, and I would have
 hoped that a large software company like Oracle would have already tried
 all possible workarounds for this requirement, and if they say it must be
 done, then it must be done. Then again, other aspects of their software
 release procedures demonstrate that perhaps they don't really know what
 they're doing.

 I was looking into this today. I did not get it to work yet. For example,
 trying to use a php-oracle function without setting DYLD_LIBRARY_PATH
 results in:

 {{{
 $ php55 -r 'oci_connect("username", "password");'
 Warning: oci_connect(): OCIEnvNlsCreate() failed. There is something wrong
 with your system - please check that DYLD_LIBRARY_PATH includes the
 directory with Oracle Instant Client libraries in Command line code on
 line 1

 Warning: oci_connect(): Error while trying to retrieve text for error
 ORA-01804
  in Command line code on line 1
 }}}

 Setting `DYLD_LIBRARY_PATH=/opt/local/lib/oracle` first, as `port notes
 oracle-instantclient` currently says to do, works around the problem.

 I tried the attached patch to oracle-instantclient, and it did not change
 the situation. Am I doing it wrong? As I said on the mailing list, I'm not
 familiar with this "rpath" concept.

-- 
Ticket URL: <https://trac.macports.org/ticket/38626#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X