[MacPorts] #37774: webkit-gtk @1.10.2+universal: WebKitDOMNavigator.h header merged incorrectly

[MacPorts]

#37774: webkit-gtk @1.10.2+universal: WebKitDOMNavigator.h header merged
incorrectly
---------------------------+------------------------
  Reporter:  ryandesign@…  |      Owner:  jeremyhu@…
      Type:  defect        |     Status:  closed
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.1.2
Resolution:  fixed         |   Keywords:  haspatch
      Port:  webkit-gtk    |
---------------------------+------------------------

Comment (by chief1983@…):

 I am still seeing problems caused by the comment in that header file.
 While building GIMP2:

 {{{
 :info:build In file included from dialog.c:34:
 :info:build In file included from
 /opt/local/include/webkitgtk-1.0/webkit/webkit.h:27:
 :info:build In file included from
 /opt/local/include/webkitgtk-1.0/webkit/webkitdom.h:135:
 :info:build
 /opt/local/include/webkitgtk-1.0/webkit/WebKitDOMNavigator.h:80:8:
 warning: '/*' within block comment [-Wcomment]
 :info:build #endif /* __LP64__ */
 :info:build        ^
 :info:build
 /opt/local/include/webkitgtk-1.0/webkit/WebKitDOMNavigator.h:81:4:
 warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
 :info:build  * webkit_dom_navigator_register_protocol_handler:
 :info:build  ~ ^
 :info:build
 /opt/local/include/webkitgtk-1.0/webkit/WebKitDOMNavigator.h:81:50: error:
 expected ';' after top level declarator
 :info:build  * webkit_dom_navigator_register_protocol_handler:
 }}}

 And so on to more failure.  I don't understand why that #ifdef was put in
 that header like that in the first place, it seems like it's shifted down
 one line from where it should be, so that it would be fully surrounding
 just one logical block of code.  Is it not possible to fix it or have a
 patch that makes it end up like so?

 {{{
 #ifndef __LP64__
 /**
  * webkit_dom_navigator_webkit_get_gamepads:
  * @self: A #WebKitDOMNavigator
  *
  * Returns: (transfer none):
  *
 **/
 WEBKIT_API WebKitDOMGamepadList*
 webkit_dom_navigator_webkit_get_gamepads(WebKitDOMNavigator* self);

 #endif /* ! __LP64__ */
 /**
  * webkit_dom_navigator_register_protocol_handler:
  * @self: A #WebKitDOMNavigator
  * @scheme: A #gchar
  * @url: A #gchar
  * @title: A #gchar
  * @error: #GError
  *
  * Returns:
  *
 **/
 }}}

 If so, there wouldn't be any issues with the comment blocks being
 terminated incorrectly.  I really don't know much about macports though
 and how this would or wouldn't work.

-- 
Ticket URL: <https://trac.macports.org/ticket/37774#comment:7>
MacPorts <http://www.macports.org/>
Ports system for OS X