[MacPorts] #41720: cmake @2.8.12: hardcoded /opt/local
MacPorts
noreply at macports.org
Sat Dec 7 04:36:07 PST 2013
#41720: cmake @2.8.12: hardcoded /opt/local
--------------------------+-------------------
Reporter: ryandesign@… | Owner: css@…
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: | Port: cmake
--------------------------+-------------------
The following files in the cmake source tarball contain the string
/opt/local, even if that is not the MacPorts prefix:
{{{
cmake-2.8.12/Modules/FindGDAL.cmake
cmake-2.8.12/Modules/FindGTK2.cmake
cmake-2.8.12/Modules/FindLua50.cmake
cmake-2.8.12/Modules/FindLua51.cmake
cmake-2.8.12/Modules/FindOpenAL.cmake
cmake-2.8.12/Modules/FindOpenThreads.cmake
cmake-2.8.12/Modules/FindPhysFS.cmake
cmake-2.8.12/Modules/FindProducer.cmake
cmake-2.8.12/Modules/FindSDL.cmake
cmake-2.8.12/Modules/FindSDL_sound.cmake
cmake-2.8.12/Modules/Findosg_functions.cmake
cmake-2.8.12/Modules/Platform/Darwin.cmake
cmake-2.8.12/Source/CPack/cmCPackDebGenerator.h
cmake-2.8.12/Source/CPack/cmCPackRPMGenerator.h
cmake-2.8.12/Tests/Contracts/Trilinos-10-6/EnvScript.cmake
cmake-2.8.12/Utilities/cmlibarchive/CMakeLists.txt
}}}
I noticed this, when a cmake-using port that succeeded building on a
machine with MacPorts prefix /opt/local, failed to find gtk2 on a machine
with a different prefix.
We should probably reinplace /opt/local to the current prefix in these
files, so that they can find the software they're supposed to be helping
to find, even if the prefix is non-standard. While we're there, we should
remove the parts of those files that would find software in /sw,
/usr/local, and other locations we never want cmake to find software in. I
already did a version of this with the patch to FindFreetype.cmake that I
committed to the cmake port recently.
--
Ticket URL: <https://trac.macports.org/ticket/41720>
MacPorts <http://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list