[MacPorts] #37974: Pallet @1.1.1 Patches for syntax warnings when using Clang and Xcode 4.6
MacPorts
noreply at macports.org
Fri Feb 8 03:21:06 PST 2013
#37974: Pallet @1.1.1 Patches for syntax warnings when using Clang and Xcode 4.6
-------------------------+--------------------------------
Reporter: iandw.au@… | Owner: macports-tickets@…
Type: defect | Status: new
Priority: Low | Milestone:
Component: contrib | Version: 2.1.3
Resolution: | Keywords: haspatch
Port: Pallet |
-------------------------+--------------------------------
Comment (by iandw.au@…):
Replying to [comment:3 ryandesign@…]:
> Replying to [ticket:37974 iandw.au@…]:
> > I have also re-worded some offensive text in a string in file
MPQueueTableView.m.diff.
>
> Changed this in r102780. I am not certain about the other changes. What
were the warnings you received?
Examples of the warning messages I was getting are shown below, as
comments, along with "before and after" code.
1) NSLog(@"Default variants count: %i", [defaultVariants count]);
// Values of type 'NSUInteger' should not be used as format
arguments;
// add an explicit cast to 'unsigned long' instead
NSLog(@"Default variants count: %li", (unsigned
long)[defaultVariants count]);
2) [variants addObject: [NSString stringWithString:@"+"]];
// Using 'stringWithString' with a literal is redundant
[variants addObject: @"+"];
These examples are from file MPActionsController.m. BTW, Pallet was
written by GSoC students in 2009 and 2010, so is not very old.
--
Ticket URL: <https://trac.macports.org/ticket/37974#comment:9>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list