[MacPorts] #37491: libgeotiff: geotifcp and EXC_BAD_ACCESS (was: geotifcp and EXC_BAD_ACCESS)

[MacPorts]

#37491: libgeotiff: geotifcp and EXC_BAD_ACCESS
--------------------------------+------------------------
  Reporter:  heikki.julkunen@…  |      Owner:  stromnov@…
      Type:  defect             |     Status:  new
  Priority:  Normal             |  Milestone:
 Component:  ports              |    Version:  2.1.2
Resolution:                     |   Keywords:  haspatch
      Port:  libgeotiff         |
--------------------------------+------------------------
Changes (by ryandesign@…):

 * priority:  High => Normal
 * keywords:   => haspatch
 * owner:  macports-tickets@… => stromnov@…
 * port:   => libgeotiff


Old description:

> geotifcp works great in Ubuntu 12.04
> The tiff file is large (316Mb) so better not attach it, please let me
> know if you need it.
>
> > port version
> Version: 2.1.2
> > uname -a
> Darwin mini.local 12.2.1 Darwin Kernel Version 12.2.1: Thu Oct 18
> 12:13:47 PDT 2012; root:xnu-2050.20.9~1/RELEASE_X86_64 x86_64
>
> geotifcp -g KSEA.orig.geo.hp KSEA.enh.tif KSEA.tif
> make: *** [KSEA.tif] Segmentation fault: 11
>

> (gdb) set args  -g KSEA.orig.geo.hp KSEA.enh.tif KSEA.tif
> (gdb) run
> Starting program: /opt/local/bin/geotifcp -g KSEA.orig.geo.hp
> KSEA.enh.tif KSEA.tif
> Reading symbols for shared libraries ++++++.............................
> done
>
> Program received signal EXC_BAD_ACCESS, Could not access memory.
> Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000018
> 0x00007fff937799e7 in memmove$VARIANT$sse42 ()
>

> Have proposed fix here:
> diff geotifcp.c.orig geotifcp.c
> 462c462
> <       { TIFFTAG_WHITEPOINT,           2, TIFF_RATIONAL },
> ---
> >       { TIFFTAG_WHITEPOINT,           (uint16) -1, TIFF_RATIONAL },
> 512,514d511
> <                       } else if (p->count == 2) {
> <                               float floatv1, floatv2;
> <                               CopyField2(p->tag, floatv1, floatv2);
> 528a526

New description:

 geotifcp works great in Ubuntu 12.04 [[br]]
 The tiff file is large (316Mb) so better not attach it, please let me know
 if you need it.

 {{{
 > port version
 Version: 2.1.2
 > uname -a
 Darwin mini.local 12.2.1 Darwin Kernel Version 12.2.1: Thu Oct 18 12:13:47
 PDT 2012; root:xnu-2050.20.9~1/RELEASE_X86_64 x86_64

 geotifcp -g KSEA.orig.geo.hp KSEA.enh.tif KSEA.tif
 make: *** [KSEA.tif] Segmentation fault: 11


 (gdb) set args  -g KSEA.orig.geo.hp KSEA.enh.tif KSEA.tif
 (gdb) run
 Starting program: /opt/local/bin/geotifcp -g KSEA.orig.geo.hp KSEA.enh.tif
 KSEA.tif
 Reading symbols for shared libraries ++++++.............................
 done

 Program received signal EXC_BAD_ACCESS, Could not access memory.
 Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000018
 0x00007fff937799e7 in memmove$VARIANT$sse42 ()
 }}}


 Have proposed fix here:
 {{{
 diff geotifcp.c.orig geotifcp.c
 462c462
 <       { TIFFTAG_WHITEPOINT,           2, TIFF_RATIONAL },
 ---
 >       { TIFFTAG_WHITEPOINT,           (uint16) -1, TIFF_RATIONAL },
 512,514d511
 <                       } else if (p->count == 2) {
 <                               float floatv1, floatv2;
 <                               CopyField2(p->tag, floatv1, floatv2);
 528a526
 }}}

--

Comment:

 Did this patch come from the developers of libgeotiff, or if not, have you
 already informed them about it and have they agreed that this is the
 correct fix? Is there an upstream bug report about this problem?

-- 
Ticket URL: <https://trac.macports.org/ticket/37491#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS