[MacPorts] #37440: gnudatalanguage: autoreconf failure with automake 1.13: macro 'AM_CONFIG_HEADER' not found in library

[MacPorts]

#37440: gnudatalanguage: autoreconf failure with automake 1.13: macro
'AM_CONFIG_HEADER' not found in library
------------------------------+-----------------------
  Reporter:  howard.teich@…   |      Owner:  takeshi@…
      Type:  defect           |     Status:  closed
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.1.2
Resolution:  fixed            |   Keywords:
      Port:  gnudatalanguage  |
------------------------------+-----------------------
Changes (by ryandesign@…):

 * cc: ryandesign@… (added)


Comment:

 > {{{
 > +compiler.blacklist          clang \
 > +                            gcc-4.0
 > }}}

 Could you add a comment explaining why clang is blacklisted?

 And what about gcc-4.0? Blacklisting that will probably cause the port to
 be unable to build on Tiger.


 > {{{
 > -variant python description {build with support for calling Python (2.6)
 from GDL (using numpy)} {
 > -    depends_lib-append      port:python26 \
 > -                            port:py26-numpy
 > -    configure.args-append   --with-
 python=${prefix}/Library/Frameworks/Python.framework/Versions/2.6 \
 > -                            --enable-python_version=2.6
 > +if {[variant_isset python]} {
 > +    return -code error "python variant is deprecated. Choose one of
 python2x variants"
 >  }
 > ...
 > +variant python description {deprecated variant choose one of python2x
 variants} {
 > +}
 > +
 > +variant python25 conflicts python26 python27 description {build with
 support for calling Python (2.5) from GDL (using numpy)} {
 > +    depends_lib-append      port:py25-numpy
 > +    configure.args-append
 -DPYTHONDIR=${frameworks_dir}/Python.framework/Versions/2.5 \
 > +                            -DPYTHONVERSION=2.5
 > +}
 > +
 > +variant python26 conflicts python25 python27 description {build with
 support for calling Python (2.6) from GDL (using numpy)} {
 > +    depends_lib-append      port:py26-numpy
 > +    configure.args-append
 -DPYTHONDIR=${frameworks_dir}/Python.framework/Versions/2.6 \
 > +                            -DPYTHONVERSION=2.6
 > +}
 > +
 > +variant python27 conflicts python25 python26 description {build with
 support for calling Python (2.7) from GDL (using numpy)} {
 > +    depends_lib-append      port:py27-numpy
 > +    configure.args-append
 -DPYTHONDIR=${frameworks_dir}/Python.framework/Versions/2.7 \
 > +                            -DPYTHONVERSION=2.7
 > +}
 > }}}

 You shouldn't use `return -code error` in the main part of the portfile,
 otherwise innocuous commands like `port info` that the user would not
 expect to fail will fail. Only use it in a phase; for example, it's often
 done in a pre-configure phase. However, in this case, the old python
 variant used python 2.6. So you could instead make the old python variant
 require the new python26 variant and thus seamlessly upgrade the user
 without bothering them with an error message.

 {{{
 variant python requires python26 description {Legacy compatibility
 variant} {}
 }}}


 > {{{
 > +variant openmp description {deprecated variant. Choose one of gcc4x
 variants.} {
 > +}
 > }}}

 The openmp variant should either do something or should be removed from
 the portfile; there's no point having a variant that does nothing.


 > {{{
 > +variant gcc45 conflicts gcc44 gcc46 gcc47 description {enabling of the
 support for OpenMP with gcc45} {
 > +    configure.compiler      macports-gcc-4.5
 > +    depends_build-append    port:gcc45
 > +    configure.args-append   -D
 > +}
 > }}}

 What does adding -D to configure.args do? I'm suspicious about this being
 required for gcc45 but not for gcc44, gcc46 or gcc47.

 Also please confirm whether the gcc4x port is only needed at build time or
 whether, as is usually the case, its library is also linked with.

-- 
Ticket URL: <https://trac.macports.org/ticket/37440#comment:6>
MacPorts <http://www.macports.org/>
Ports system for Mac OS