[MacPorts] #35339: zorba: Update to 2.5 release

[MacPorts]

#35339: zorba: Update to 2.5 release
-----------------------------+--------------------------------
  Reporter:  cezar.andrei@…  |      Owner:  macports-tickets@…
      Type:  update          |     Status:  new
  Priority:  Normal          |  Milestone:
 Component:  ports           |    Version:
Resolution:                  |   Keywords:  haspatch
      Port:  zorba           |
-----------------------------+--------------------------------

Comment (by ryandesign@…):

 We would prefer unified diffs (like you had attached for the 2.5 update)
 instead of complete portfiles (like you attached for the 2.7 and 2.8
 updates).

 There are several changes I would make to the 2.8 Portfile, including
 removing commented-out lines that aren't needed, not hardcoding the
 version in the distfiles and checksums, ordering the dependencies
 alphabetically, and using spaces instead of tabs to match the rest of the
 portfile.

 If old versions of clang cannot build zorba they should be blacklisted
 using the compiler_blacklist_versions portgroup.

 I tried the 2.8 portfile and the checksums didn't match. I assume the
 distfile changed after you put the checksums into the portfile. I see the
 distfile is being fetched from http://my.zorba-xquery.com/tmp/ instead of
 the previous launchpad URL. The launchpad URL is still the one listed on
 the zorba web site. The zorba web site lists 2.7 as the latest version. I
 think we should use the latest released version, not a prerelease. Also I
 was confused why a dependency on the libarchive port is added (which means
 you want to use libarchive) but also a configure arg
 "-DZORBA_SUPPRESS_LIBARCHIVE=YES" is added (which suggests to me you don't
 want to use libarchive).

 I went to the 2.7 portfile you attached previously. It too is set to
 download from the above temporary URL. The checksums match, but the file
 it downloads is different from the file of the same name offered at
 launchpad in the following ways:

 {{{
 Only in zorba-2.7.0-launchpad: .bzrignoreOnly in
 zorba-2.7.0-launchpad/src/compiler/codegen: plan_visitor.cpp.~1~
 Only in zorba-2.7.0-launchpad/src/diagnostics: diagnostic_en.xml.~1~
 Only in zorba-2.7.0-tmp/src/runtime/core: pregenerated
 Only in zorba-2.7.0-launchpad/src/runtime/errors_and_diagnostics:
 errors_and_diagnostics_impl.cpp.~1~
 Only in zorba-2.7.0-tmp/src/runtime/eval: pregenerated
 Only in zorba-2.7.0-launchpad/src/runtime/json:
 jsoniq_functions_impl.cpp.~1~
 Only in zorba-2.7.0-tmp/src/runtime: rest
 Only in zorba-2.7.0-tmp/src/runtime/scripting: pregenerated
 Only in zorba-2.7.0-tmp/src/runtime/spec: reflection
 Only in zorba-2.7.0-tmp/src/runtime/spec: scripting
 Only in zorba-2.7.0-launchpad/src/store/naive: node_items.cpp.~1~
 Only in zorba-2.7.0-launchpad/src/store/naive: pul_primitives.cpp.~1~
 Only in zorba-2.7.0-tmp/test: coverity
 Only in zorba-2.7.0-tmp/test/rbkt/ExpQueryResults/zorba/collections:
 delete_nodes_first
 Only in zorba-2.7.0-tmp/test/rbkt/ExpQueryResults/zorba/collections:
 delete_nodes_last
 Only in zorba-2.7.0-tmp/test/rbkt/Queries/zorba/utf-8: xml_files
 }}}

 I don't know the significance of these differences. I wanted to switch to
 launchpad as the download URL, but launchpad does not have the modules
 file that the port downloads. Why is that file only available on your site
 in a temporary directory? There is a modules file at launchpad for zorba
 2.6.

 This is all very confusing. What should we do?

-- 
Ticket URL: <https://trac.macports.org/ticket/35339#comment:9>
MacPorts <http://www.macports.org/>
Ports system for Mac OS