[MacPorts] #33575: NEW: stimfit

[MacPorts]

#33575: NEW: stimfit
-------------------------+--------------------------------
  Reporter:  christsc@…  |      Owner:  macports-tickets@…
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:
      Port:  stimfit     |
-------------------------+--------------------------------

Comment (by christsc@…):

 Thanks for your review.

 Replying to [comment:17 ciserlohn@…]:
 > Before including into MacPorts some questions and remarks:
 >
 > {{{
 > license             GPL
 > }}}
 > - Can you indicate the version (e.g. GPL-2)?

 Fixed in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3
 r5ed64d7830c3].

 > {{{
 > supported_archs     x86_64
 > }}}
 > - really no i386 and PowerPC? The debian repository you mentioned
 provides packages for both.

 Added i386 in
 [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3
 r5ed64d7830c3]. File I/O depends on endianness //and// OS; including ppc
 would require some thorough testing.

 > {{{
 > if {![variant_isset python27]} {
 >     default_variants +python27
 > }
 > }}}
 > - The {{{default_variants}}} should not be inside a if block. This idiom
 makes only sense if you have more than on python variant and would like to
 make one the default if none had explicitly chosen by the user.

 Commented out in
 [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3
 r5ed64d7830c3], pending availability of wxPython for Python 3.x.

 > {{{
 > variant python27 description {Build with Python shell. Only 2.7 is
 supported.}
 > }}}
 > - {{{ Only 2.7 is supported}}} should not be in the variant description
 but moved to a comment.

 Fixed in [https://code.google.com/p/stimfit/source/detail?r=5ed64d7830c3
 r5ed64d7830c3].

 Some additional fixes to address relevant issues from
 [https://trac.macports.org/ticket/37471#comment:18 Ticket 37471#comment18]
 were added in
 [https://code.google.com/p/stimfit/source/detail?r=609ada02fd6a
 r609ada02fd6a] and
 [https://code.google.com/p/stimfit/source/detail?r=45f538cbfddc
 r45f538cbfddc].

-- 
Ticket URL: <https://trac.macports.org/ticket/33575#comment:20>
MacPorts <http://www.macports.org/>
Ports system for OS X