[MacPorts] #38321: gnuplot @4.6.1 Enhancement: add variant for old bitmap formats

MacPorts noreply at macports.org
Wed Mar 13 13:48:15 PDT 2013


#38321: gnuplot @4.6.1 Enhancement: add variant for old bitmap formats
--------------------------+----------------------
  Reporter:  predoehl@…   |      Owner:  mojca@…
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.1.3
Resolution:               |   Keywords:  haspatch
      Port:  gnuplot      |
--------------------------+----------------------

Comment (by predoehl@…):

 Replying to [comment:3 mojca@…]:

 - '''Clearer name''':  I agree, my suggested name above was cryptic -- I
 was trying to be very brief (which seemed to be the norm), but let's be
 clearer if that is OK.  I think a longer, clearer name like
 {{{old_bitmap_terminals}}} would better communicate the semi-obsolete
 nature of the option.

 - '''To add a variant or not?'''  I think on balance, it's better to add
 this extra option.  One way to justify it is by considering this:  the
 Gnuplot devs decided it would be good to turn off (by default) all those
 old terminal formats, yet keep them available through a configuration
 option.  By adding this port variant, the port faithfully reflects the
 configuration structure of the Gnuplot project.  Furthermore, the Gnuplot
 devs might have had good reasons to make those old terminal options opt-in
 rather than opt-out, so I think it's probably smart to organize the port
 the same way (i.e., also opt-in).

 - '''Better description''':
 > For the description I would use something like "Enable PBM/Portable Bit
 Map (and other older bitmap terminals)".
 >
  That sounds good.

 - '''Version number increment''':  I notice my above patch erroneously
 increments the {{{version}}} variable, whereas I meant to increment the
 version of the port itself (from 2.1.3 to 2.1.4, I suppose).  Oops.  But
 it is fine with me to hold onto this patch until after the new Gnuplot
 version is released.

 Thanks for the feedback!

-- 
Ticket URL: <https://trac.macports.org/ticket/38321#comment:4>
MacPorts <http://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list