[MacPorts] #38993: xorg-server, xorg-server-devel crash at "damageValidateGC"
MacPorts
noreply at macports.org
Tue May 7 07:52:06 PDT 2013
#38993: xorg-server, xorg-server-devel crash at "damageValidateGC"
--------------------------------+------------------------
Reporter: kurtjaeke@… | Owner: jeremyhu@…
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.1.3
Resolution: | Keywords:
Port: xorg-server-devel |
--------------------------------+------------------------
Comment (by kurtjaeke@…):
I played a little with "git bisect".
Upstream commit 4dc2a76740d921c824a4d8193f39dd373475f02a
("http://cgit.freedesktop.org/xorg/xserver/commit/?id=4dc2a76740d921c824a4d8193f39dd373475f02a")
causes the problems I see. '''Reverting''' the following part of the first
hunk makes this issue go away for me:
{{{
diff --git a/miext/damage/damage.c b/miext/damage/damage.c
index 2d2b422..a98c20e 100644
--- a/miext/damage/damage.c
+++ b/miext/damage/damage.c
@@ -436,9 +436,13 @@ damageCreateGC(GCPtr pGC)
static void
damageValidateGC(GCPtr pGC, unsigned long changes, DrawablePtr pDrawable)
{
DAMAGE_GC_FUNC_PROLOGUE(pGC);
(*pGC->funcs->ValidateGC) (pGC, changes, pDrawable);
- pGCPriv->ops = pGC->ops; /* just so it's not NULL */
+ if (pDamage)
+ pGCPriv->ops = pGC->ops; /* so it's not NULL, so FUNC_EPILOGUE does work
*/
+ else
+ pGCPriv->ops = NULL;
DAMAGE_GC_FUNC_EPILOGUE(pGC);
}
}}}
This is where my investigation stops.
What's next?
--
Ticket URL: <https://trac.macports.org/ticket/38993#comment:7>
MacPorts <http://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list